Cannot create DAX client with session - InvalidParameter: custom handlers not supported

[edulopezTriv]

I'm trying to create a DAX client with dax.NewWithSession using the same session I use for creating a dynamo client. I can confirm it works with dynamo.

Sample

sess, err := GetSession()
if err != nil {
	return nil, err
}
if useDAX {
	svc, err = dax.NewWithSession(sess)
} else {
	svc = dynamodb.New(sess)
}

this is the error I have when calling dax.NewWithSession

InvalidParameter: custom handlers not supported

If you read the code from aws-dax-go that error comes from client.ValidateHandlers

What should we do to create a new DAX client using our aws session?

Env

github.com/aws/aws-dax-go v1.1.1
github.com/aws/aws-sdk-go v1.19.48

[VasilyFomin]

We indeed do not support custom handlers, but probably a warning will be sufficient, otherwise you'll have to provide/modify a separate session for the Dax client.

Are you providing custom handlers?

[edulopezTriv]

We indeed do not support custom handlers, but probably a warning will be sufficient, otherwise you'll have to provide/modify a separate session for the Dax client.

Are you providing custom handlers?

Nope. I'm just using my session object created with AWS sdk.

I'm worried that dax.NewWithSession has a bug.

[dspinei]

The error reported by @edulopezTriv can be reproduced simply with:

	sess, _ := session.NewSession()
	return dax.NewWithSession(*sess)

Looks like a default Session created with aws-sdk-go already contains handlers that are considered custom by the dax sdk.

Env

github.com/aws/aws-dax-go v1.1.4
github.com/aws/aws-sdk-go v1.18.6

[VasilyFomin]

After looking into it somewhat more, I think we're going to deprecate this constructor all together.

The reason we have validations is because DAX doesn't use custom configurations and handlers and we want to make sure a customer is aware of this. Essentially the only fields we're using from the session objects are some of the configurations:

aws-dax-go/dax/service.go

Lines 86 to 107 in 19b34c5

	func (c *Config) mergeFrom(ac aws.Config) {
	if r := ac.MaxRetries; r != nil {
	c.WriteRetries = *r
	c.ReadRetries = *r
	}
	if ac.Logger != nil {
	c.Logger = ac.Logger
	}
	if ac.LogLevel != nil {
	c.LogLevel = *ac.LogLevel
	}
	if ac.Credentials != nil {
	c.Credentials = ac.Credentials
	}
	if ac.Endpoint != nil {
	c.HostPorts = []string{*ac.Endpoint}
	}
	if ac.Region != nil {
	c.Region = *ac.Region
	}
	}

Which essentially means you'll have to modify your existing session anyway, to get it working with DAX, at which point you might as well create a new DAX configuration.

What's your use case when you use an existing session? How do you set the dax endpoint?

[edulopezTriv]

The thing is I may use that session to any other thing in my project. I rather have a NewDaxWithCredentials(session) that takes what it needs from it instead of having to change it.

[VasilyFomin]

The problem is it wont' work, because you will still have to modify the session's Endpoint to point to your dax cluster

[dspinei]

you will still have to modify the session's Endpoint to point to your dax cluster

I don't think that's the issue. I think the expectation is that the following code, that is familiar across AWS SDKs, works:

sess, _ := session.NewSession(&aws.Config{
	Endpoint: aws.String(daxURL),
	Region:   aws.String(daxRegion),
})
return dax.NewWithSession(*sess)

[lyaoxion]

This was fixed in v1.2.0. Creation of DAX client from a Session will not throw out an error as long as all required configurations is provided in the Session.

[hmayi]

@lyaoxion @dspinei Have you guys upgraded the DAX client using SDKV2?

[miparnisari]

@hmayi there is an open PR from the community: #43

But it hasn't received any attention from the maintainers of DAX. ☹️

[hmayi]

Thanks for the reply. Were you able to create sessions with SDK1? Regards Hiranmayi.

…

On Thu, Feb 8, 2024 at 11:42 PM Maria Ines Parnisari < ***@***.***> wrote: @hmayi <https://github.com/hmayi> there is an open PR from the community: #43 <#43> But it hasn't received any attention from the maintainers of DAX. ☹️ — Reply to this email directly, view it on GitHub <#17 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAN6RG7DMOQ7GX3NPGSNXLTYSWSMZAVCNFSM4IYYUIW2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJTGUZTENJUGQ2Q> . You are receiving this because you were mentioned.Message ID: ***@***.***>