Fix intermittent IAM permission failures in delete-deployment command

Author: AlexDaines

.autover/changes/d5f415cd-080b-41e1-8256-8743f7a423d3.json

@@ -0,0 +1,11 @@
+{
+  "Projects": [
+    {
+      "Name": "AWS.Deploy.CLI",
+      "Type": "Patch",
+      "ChangelogMessages": [
+        "Fixed intermittent IAM permission failures in delete-deployment command by ensuring CloudFormation client is created after AWS credentials are configured"
+      ]
+    }
+  ]
+}

src/AWS.Deploy.CLI/Commands/DeleteDeploymentCommand.cs

@@ -28,12 +28,12 @@ public class DeleteDeploymentCommand : CancellableAsyncCommand<DeleteDeploymentC
 
     private readonly IAWSClientFactory _awsClientFactory;
     private readonly IToolInteractiveService _interactiveService;
-    private readonly IAmazonCloudFormation _cloudFormationClient;
     private readonly IConsoleUtilities _consoleUtilities;
     private readonly ILocalUserSettingsEngine _localUserSettingsEngine;
     private readonly IAWSUtilities _awsUtilities;
     private readonly IProjectParserUtility _projectParserUtility;
     private readonly IAWSResourceQueryer _awsResourceQueryer;
+    private IAmazonCloudFormation? _cloudFormationClient;
     private const int MAX_RETRIES = 4;
 
     /// <summary>
@@ -51,7 +51,6 @@ public DeleteDeploymentCommand(
         _awsClientFactory = awsClientFactory;
         _interactiveService = interactiveService;
         _consoleUtilities = consoleUtilities;
-        _cloudFormationClient = _awsClientFactory.GetAWSClient<IAmazonCloudFormation>();
         _localUserSettingsEngine = localUserSettingsEngine;
         _awsUtilities = awsUtilities;
         _projectParserUtility = projectParserUtility;
@@ -80,6 +79,9 @@ public override async Task<int> ExecuteAsync(CommandContext context, DeleteDeplo
             awsOption.Region = RegionEndpoint.GetBySystemName(awsRegion);
         });
 
+        // Create CloudFormation client after credentials are configured
+        _cloudFormationClient = _awsClientFactory.GetAWSClient<IAmazonCloudFormation>();
+
         if (string.IsNullOrEmpty(settings.DeploymentName))
         {
             _interactiveService.WriteErrorLine(string.Empty);
@@ -123,7 +125,7 @@ public override async Task<int> ExecuteAsync(CommandContext context, DeleteDeplo
 
         try
         {
-            await _cloudFormationClient.DeleteStackAsync(new DeleteStackRequest
+            await _cloudFormationClient!.DeleteStackAsync(new DeleteStackRequest
             {
                 StackName = settings.DeploymentName
             });
@@ -218,7 +220,7 @@ private async Task WaitForStackDelete(string stackName)
             {
                 await Task.Delay(waitTime);
 
-                var response = await _cloudFormationClient.DescribeStacksAsync(new DescribeStacksRequest
+                var response = await _cloudFormationClient!.DescribeStacksAsync(new DescribeStacksRequest
                 {
                     StackName = stackName
                 });