fix(testing): floor callback timer scaling

Author: zhongkechen

packages/aws-durable-execution-sdk-python-testing/src/aws_durable_execution_sdk_python_testing/executor.py

@@ -72,6 +72,8 @@
 
 logger = logging.getLogger(__name__)
 
+_CALLBACK_TIMEOUT_MINIMUM_DELAY_SECONDS = 5.0
+
 
 class Executor(ExecutionObserver):
     MAX_CONSECUTIVE_FAILED_ATTEMPTS: int = 5
@@ -1094,7 +1096,10 @@ def _schedule_callback_timeouts(
 
             # Schedule main timeout if configured
             if callback_options.timeout_seconds > 0:
-                timeout_delay = scale_delay(callback_options.timeout_seconds)
+                timeout_delay = scale_delay(
+                    callback_options.timeout_seconds,
+                    minimum=_CALLBACK_TIMEOUT_MINIMUM_DELAY_SECONDS,
+                )
 
                 def timeout_handler():
                     self._on_callback_timeout(execution_arn, callback_id)
@@ -1109,7 +1114,8 @@ def timeout_handler():
             # Schedule heartbeat timeout if configured
             if callback_options.heartbeat_timeout_seconds > 0:
                 heartbeat_delay = scale_delay(
-                    callback_options.heartbeat_timeout_seconds
+                    callback_options.heartbeat_timeout_seconds,
+                    minimum=_CALLBACK_TIMEOUT_MINIMUM_DELAY_SECONDS,
                 )
 
                 def heartbeat_timeout_handler():
@@ -1154,7 +1160,8 @@ def _reset_callback_heartbeat_timeout(
 
             if callback_options and callback_options.heartbeat_timeout_seconds > 0:
                 heartbeat_delay = scale_delay(
-                    callback_options.heartbeat_timeout_seconds
+                    callback_options.heartbeat_timeout_seconds,
+                    minimum=_CALLBACK_TIMEOUT_MINIMUM_DELAY_SECONDS,
                 )
 
                 def heartbeat_timeout_handler():

packages/aws-durable-execution-sdk-python-testing/src/aws_durable_execution_sdk_python_testing/time_scale.py

@@ -27,6 +27,10 @@ def get_time_scale() -> float:
     return scale
 
 
-def scale_delay(delay: float | int) -> float:
+def scale_delay(delay: float | int, *, minimum: float = 0) -> float:
     """Scale a durable timer delay for local testing."""
-    return float(delay) * get_time_scale()
+    scaled_delay = float(delay) * get_time_scale()
+    if minimum <= 0:
+        return scaled_delay
+
+    return max(scaled_delay, min(float(delay), minimum))

packages/aws-durable-execution-sdk-python-testing/tests/executor_test.py

@@ -2579,16 +2579,31 @@ def test_callback_timeout_scheduling(executor, mock_store, mock_scheduler):
 def test_callback_timeout_scheduling_scales_delays(
     executor, mock_store, mock_scheduler, monkeypatch
 ):
-    """Test that callback timeout timers honor local time scaling."""
+    """Test that callback timeout timers honor local time scaling with a floor."""
     monkeypatch.setenv("DURABLE_EXECUTION_TIME_SCALE", "0.05")
     callback_options = CallbackOptions(timeout_seconds=60, heartbeat_timeout_seconds=30)
     executor._completion_events["test-arn"] = Mock()
 
     executor._schedule_callback_timeouts("test-arn", callback_options, "callback-id")
 
     timeout_call, heartbeat_call = mock_scheduler.call_later.call_args_list
-    assert timeout_call.kwargs["delay"] == 3.0
-    assert heartbeat_call.kwargs["delay"] == 1.5
+    assert timeout_call.kwargs["delay"] == 5.0
+    assert heartbeat_call.kwargs["delay"] == 5.0
+
+
+def test_callback_timeout_scheduling_keeps_short_delays(
+    executor, mock_store, mock_scheduler, monkeypatch
+):
+    """Test that short callback timeout timers are not inflated by the floor."""
+    monkeypatch.setenv("DURABLE_EXECUTION_TIME_SCALE", "0.05")
+    callback_options = CallbackOptions(timeout_seconds=1, heartbeat_timeout_seconds=2)
+    executor._completion_events["test-arn"] = Mock()
+
+    executor._schedule_callback_timeouts("test-arn", callback_options, "callback-id")
+
+    timeout_call, heartbeat_call = mock_scheduler.call_later.call_args_list
+    assert timeout_call.kwargs["delay"] == 1.0
+    assert heartbeat_call.kwargs["delay"] == 2.0
 
 
 def test_callback_timeout_cleanup(executor, mock_store):
@@ -2646,7 +2661,7 @@ def test_callback_heartbeat_timeout_reset(executor, mock_store, mock_scheduler):
 def test_callback_heartbeat_timeout_reset_scales_delay(
     executor, mock_store, mock_scheduler, monkeypatch
 ):
-    """Test that reset heartbeat timers honor local time scaling."""
+    """Test that reset heartbeat timers honor local time scaling with a floor."""
     monkeypatch.setenv("DURABLE_EXECUTION_TIME_SCALE", "0.05")
     callback_token = CallbackToken(execution_arn="test-arn", operation_id="op-123")
     callback_id = callback_token.to_str()
@@ -2665,7 +2680,7 @@ def test_callback_heartbeat_timeout_reset_scales_delay(
     executor._reset_callback_heartbeat_timeout(callback_id, "test-arn")
 
     mock_scheduler.call_later.assert_called_once()
-    assert mock_scheduler.call_later.call_args.kwargs["delay"] == 1.5
+    assert mock_scheduler.call_later.call_args.kwargs["delay"] == 5.0
 
 
 def test_callback_timeout_handlers(executor, mock_store):