Fix race condition in service tests

Author: sfodagain

identity/tests/v2ClientTests.cpp

@@ -79,8 +79,8 @@ static std::shared_ptr<Aws::Crt::Mqtt5::Mqtt5Client> s_createProtocolClient5(Aws
                 {
                     std::lock_guard<std::mutex> guard(lock);
                     connected = true;
+                    signal.notify_all();
                 }
-                signal.notify_all();
             });
 
         client = Aws::Crt::Mqtt5::Mqtt5Client::NewMqtt5Client(mqtt5Options, allocator);
@@ -145,8 +145,8 @@ static std::shared_ptr<Aws::Crt::Mqtt::MqttConnection> s_createProtocolClient311
             {
                 std::lock_guard<std::mutex> guard(lock);
                 connected = true;
+                signal.notify_all();
             }
-            signal.notify_all();
         };
 
         auto uuid = Aws::Crt::UUID().ToString();

jobs/tests/v2ClientTests.cpp

@@ -65,8 +65,8 @@ static std::shared_ptr<Aws::Crt::Mqtt5::Mqtt5Client> s_createProtocolClient5(Aws
                 {
                     std::lock_guard<std::mutex> guard(lock);
                     connected = true;
+                    signal.notify_all();
                 }
-                signal.notify_all();
             });
 
         client = Aws::Crt::Mqtt5::Mqtt5Client::NewMqtt5Client(mqtt5Options, allocator);
@@ -131,8 +131,8 @@ static std::shared_ptr<Aws::Crt::Mqtt::MqttConnection> s_createProtocolClient311
             {
                 std::lock_guard<std::mutex> guard(lock);
                 connected = true;
+                signal.notify_all();
             }
-            signal.notify_all();
         };
 
         auto uuid = Aws::Crt::UUID().ToString();

shadow/tests/v2ClientTests.cpp

@@ -76,8 +76,8 @@ static std::shared_ptr<Aws::Crt::Mqtt5::Mqtt5Client> s_createProtocolClient5(Aws
                 {
                     std::lock_guard<std::mutex> guard(lock);
                     connected = true;
+                    signal.notify_all();
                 }
-                signal.notify_all();
             });
 
         client = Aws::Crt::Mqtt5::Mqtt5Client::NewMqtt5Client(mqtt5Options, allocator);
@@ -142,8 +142,8 @@ static std::shared_ptr<Aws::Crt::Mqtt::MqttConnection> s_createProtocolClient311
             {
                 std::lock_guard<std::mutex> guard(lock);
                 connected = true;
+                signal.notify_all();
             }
-            signal.notify_all();
         };
 
         auto uuid = Aws::Crt::UUID().ToString();
@@ -620,4 +620,4 @@ static int s_ShadowV2ClientDeltaUpdateNamedShadow311(Aws::Crt::Allocator *alloca
 
     return result;
 }
-AWS_TEST_CASE(ShadowV2ClientDeltaUpdateNamedShadow311, s_ShadowV2ClientDeltaUpdateNamedShadow311)
+AWS_TEST_CASE(ShadowV2ClientDeltaUpdateNamedShadow311, s_ShadowV2ClientDeltaUpdateNamedShadow311)