Skip to content

Commit 52892bd

Browse files
Boxed types in SDK structures (#6)
* Imported SDK from generator with boxed integral types * Fixed long literals that upset boxed Long * PR Feedback, removed version finagling from shadow sample
1 parent 63d7ea0 commit 52892bd

15 files changed

Lines changed: 22 additions & 27 deletions

samples/Jobs/src/main/java/jobs/JobsSample.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ public void onConnectionResumed(boolean sessionPresent) {
252252
publishRequest.thingName = thingName;
253253
publishRequest.jobId = jobId;
254254
publishRequest.includeJobDocument = true;
255-
publishRequest.executionNumber = 1;
255+
publishRequest.executionNumber = 1L;
256256
jobs.PublishDescribeJobExecution(publishRequest);
257257
gotResponse.get();
258258
}
@@ -270,7 +270,7 @@ public void onConnectionResumed(boolean sessionPresent) {
270270

271271
StartNextPendingJobExecutionRequest publishRequest = new StartNextPendingJobExecutionRequest();
272272
publishRequest.thingName = thingName;
273-
publishRequest.stepTimeoutInMinutes = 15;
273+
publishRequest.stepTimeoutInMinutes = 15L;
274274
jobs.PublishStartNextPendingJobExecution(publishRequest);
275275

276276
gotResponse.get();

samples/Shadow/src/main/java/jobs/ShadowSample.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ public class ShadowSample {
5656
static MqttConnection connection;
5757
static IotShadowClient shadow;
5858
static String localValue = null;
59-
static int shadowVersion = 1;
6059
static CompletableFuture<Void> gotResponse;
6160

6261
static void printUsage() {
@@ -124,7 +123,6 @@ static void parseCommandLine(String[] args) {
124123
static void onGetShadowAccepted(GetShadowResponse response) {
125124
System.out.println("Received initial shadow state");
126125

127-
shadowVersion = response.version;
128126
if (response.state != null && localValue == null) {
129127
gotResponse.complete(null);
130128
if (response.state.delta != null) {
@@ -158,7 +156,6 @@ static void onGetShadowRejected(ErrorResponse response) {
158156

159157
static void onShadowDeltaUpdated(ShadowDeltaUpdatedEvent response) {
160158
System.out.println("Shadow delta updated");
161-
shadowVersion = response.version;
162159
if (response.state != null && response.state.containsKey(SHADOW_PROPERTY)) {
163160
String value = response.state.get(SHADOW_PROPERTY).toString();
164161
System.out.println(" Delta wants to change value to '" + value + "'. Changing local value...");
@@ -171,7 +168,6 @@ static void onShadowDeltaUpdated(ShadowDeltaUpdatedEvent response) {
171168
static void onUpdateShadowAccepted(UpdateShadowResponse response) {
172169
String value = response.state.reported.get(SHADOW_PROPERTY).toString();
173170
System.out.println("Shadow updated, value is " + value);
174-
shadowVersion = response.version;
175171
gotResponse.complete(null);
176172
}
177173

@@ -195,7 +191,6 @@ static CompletableFuture<Void> changeShadowValue(String value) {
195191
// build a request to let the service know our current value and desired value, and that we only want
196192
// to update if the version matches the version we know about
197193
UpdateShadowRequest request = new UpdateShadowRequest();
198-
request.version = shadowVersion;
199194
request.thingName = thingName;
200195
request.state = new ShadowState();
201196
request.state.reported = new HashMap<String, Object>() {{
@@ -295,7 +290,7 @@ public void onConnectionResumed(boolean sessionPresent) {
295290
String newValue = "";
296291
Scanner scanner = new Scanner(System.in);
297292
while (true) {
298-
System.out.print(SHADOW_PROPERTY + "(" + shadowVersion + ")> ");
293+
System.out.print(SHADOW_PROPERTY + "> ");
299294
System.out.flush();
300295
newValue = scanner.next();
301296
if (newValue.compareToIgnoreCase("quit") == 0) {

sdk/src/main/java/software/amazon/awssdk/iot/iotjobs/model/DescribeJobExecutionRequest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@
1919

2020

2121
public class DescribeJobExecutionRequest {
22-
public boolean includeJobDocument;
22+
public Boolean includeJobDocument;
2323
public String jobId;
2424
public String clientToken;
25-
public long executionNumber;
25+
public Long executionNumber;
2626
public String thingName;
2727
}

sdk/src/main/java/software/amazon/awssdk/iot/iotjobs/model/JobExecutionData.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@ public class JobExecutionData {
2525
public String jobId;
2626
public String thingName;
2727
public HashMap<String, Object> jobDocument;
28-
public long executionNumber;
28+
public Long executionNumber;
2929
public HashMap<String, String> statusDetails;
3030
public JobStatus status;
31-
public int versionNumber;
31+
public Integer versionNumber;
3232
public Timestamp queuedAt;
3333
public Timestamp lastUpdatedAt;
3434
public Timestamp startedAt;

sdk/src/main/java/software/amazon/awssdk/iot/iotjobs/model/JobExecutionState.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import software.amazon.awssdk.iot.iotjobs.model.JobStatus;
2222

2323
public class JobExecutionState {
24-
public int versionNumber;
24+
public Integer versionNumber;
2525
public HashMap<String, String> statusDetails;
2626
public JobStatus status;
2727
}

sdk/src/main/java/software/amazon/awssdk/iot/iotjobs/model/JobExecutionSummary.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121

2222
public class JobExecutionSummary {
2323
public Timestamp lastUpdatedAt;
24-
public long executionNumber;
25-
public int versionNumber;
24+
public Long executionNumber;
25+
public Integer versionNumber;
2626
public String jobId;
2727
public Timestamp startedAt;
2828
public Timestamp queuedAt;

sdk/src/main/java/software/amazon/awssdk/iot/iotjobs/model/StartNextPendingJobExecutionRequest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,5 @@ public class StartNextPendingJobExecutionRequest {
2323
public String clientToken;
2424
public String thingName;
2525
public HashMap<String, String> statusDetails;
26-
public long stepTimeoutInMinutes;
26+
public Long stepTimeoutInMinutes;
2727
}

sdk/src/main/java/software/amazon/awssdk/iot/iotjobs/model/UpdateJobExecutionRequest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@
2222

2323
public class UpdateJobExecutionRequest {
2424
public String thingName;
25-
public int expectedVersion;
26-
public long executionNumber;
27-
public boolean includeJobDocument;
25+
public Integer expectedVersion;
26+
public Long executionNumber;
27+
public Boolean includeJobDocument;
2828
public HashMap<String, String> statusDetails;
29-
public boolean includeJobExecutionState;
29+
public Boolean includeJobExecutionState;
3030
public JobStatus status;
3131
public String jobId;
3232
public String clientToken;

sdk/src/main/java/software/amazon/awssdk/iot/iotshadow/model/DeleteShadowResponse.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,5 @@
2121

2222
public class DeleteShadowResponse {
2323
public Timestamp timestamp;
24-
public int version;
24+
public Integer version;
2525
}

sdk/src/main/java/software/amazon/awssdk/iot/iotshadow/model/ErrorResponse.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,5 @@ public class ErrorResponse {
2323
public String message;
2424
public String clientToken;
2525
public Timestamp timestamp;
26-
public int code;
26+
public Integer code;
2727
}

0 commit comments

Comments
 (0)