Skip to content

Commit 83660fb

Browse files
authored
*: update SDK dependency, fix VPC deletes (#179)
* vendor: update AWS SDK Go Signed-off-by: Gyuho Lee <leegyuho@amazon.com> * eks/cluster/vpc: update "HasMoreThan2Azs" Signed-off-by: Gyuho Lee <leegyuho@amazon.com> * eks/cluster/vpc: fix subnet deletion ref. DELETE_FAILED The vpc vpc-028d8568a626d6052 currently has a subnet within CIDR block 10.2.0.0/16 (Service: AmazonEC2; Status Code: 400; Error Code: InvalidCidrBlock.InUse; Request ID: 61cfbfa2-e53b-406d-81ed-3b216cd01a99; Proxy: null) Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
1 parent 41b6349 commit 83660fb

File tree

8 files changed

+72
-34
lines changed

8 files changed

+72
-34
lines changed

CHANGELOG/CHANGELOG-1.5.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<hr>
44

55

6-
## [v1.5.3](https://github.com/aws/aws-k8s-tester/releases/tag/v1.5.3) (2020-10-14)
6+
## [v1.5.3](https://github.com/aws/aws-k8s-tester/releases/tag/v1.5.3) (2020-10-20)
77

88
See [code changes](https://github.com/aws/aws-k8s-tester/compare/v1.5.2...v1.5.3).
99

@@ -27,7 +27,7 @@ See [code changes](https://github.com/aws/aws-k8s-tester/compare/v1.5.2...v1.5.3
2727

2828
### Dependency
2929

30-
- Upgrade [`github.com/aws/aws-sdk-go`](https://github.com/aws/aws-sdk-go/releases) from [`v1.34.22`](https://github.com/aws/aws-sdk-go/releases/tag/v1.34.22) to [`v1.35.8`](https://github.com/aws/aws-sdk-go/releases/tag/v1.35.8).
30+
- Upgrade [`github.com/aws/aws-sdk-go`](https://github.com/aws/aws-sdk-go/releases) from [`v1.34.22`](https://github.com/aws/aws-sdk-go/releases/tag/v1.34.22) to [`v1.35.10`](https://github.com/aws/aws-sdk-go/releases/tag/v1.35.10).
3131

3232
### Go
3333

eks/cluster/vpc.go

Lines changed: 24 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -148,30 +148,16 @@ Parameters:
148148
Description: The IPv4 addresses of up to four domain name servers, or AmazonProvidedDNS.
149149
150150
Conditions:
151-
Has2Azs:
152-
Fn::Or:
153-
- Fn::Equals:
154-
- {Ref: 'AWS::Region'}
155-
- ap-south-1
156-
- Fn::Equals:
157-
- {Ref: 'AWS::Region'}
158-
- ap-northeast-2
159-
- Fn::Equals:
160-
- {Ref: 'AWS::Region'}
161-
- ca-central-1
162-
- Fn::Equals:
163-
- {Ref: 'AWS::Region'}
164-
- cn-north-1
165-
- Fn::Equals:
166-
- {Ref: 'AWS::Region'}
167-
- sa-east-1
168-
- Fn::Equals:
169-
- {Ref: 'AWS::Region'}
170-
- us-west-1
171151
172152
HasMoreThan2Azs:
173153
Fn::Not:
174-
- Condition: Has2Azs
154+
- Fn::Or:
155+
- Fn::Equals:
156+
- Ref: AWS::Region
157+
- cn-north-1
158+
- Fn::Equals:
159+
- Ref: AWS::Region
160+
- us-isob-east-1
175161
176162
HasDHCPOptionsOnlyDomainName:
177163
Fn::And:
@@ -234,11 +220,13 @@ Resources:
234220
Properties:
235221
VpcId: !Ref VPC
236222
CidrBlock: !Ref VPCBlock2
223+
237224
VPCCIDRBlock3:
238225
Type: AWS::EC2::VPCCidrBlock
239226
Properties:
240227
VpcId: !Ref VPC
241228
CidrBlock: !Ref VPCBlock3
229+
242230
VPCCIDRBlock4:
243231
Type: AWS::EC2::VPCCidrBlock
244232
Properties:
@@ -259,6 +247,9 @@ Resources:
259247
DependsOn:
260248
- VPC
261249
- VPCGatewayAttachment
250+
- VPCCIDRBlock2
251+
- VPCCIDRBlock3
252+
- VPCCIDRBlock4
262253
Metadata:
263254
Comment: Public Subnet 1, https://docs.aws.amazon.com/eks/latest/userguide/alb-ingress.html
264255
Properties:
@@ -281,6 +272,9 @@ Resources:
281272
DependsOn:
282273
- VPC
283274
- VPCGatewayAttachment
275+
- VPCCIDRBlock2
276+
- VPCCIDRBlock3
277+
- VPCCIDRBlock4
284278
Metadata:
285279
Comment: Public Subnet 2, https://docs.aws.amazon.com/eks/latest/userguide/alb-ingress.html
286280
Properties:
@@ -304,6 +298,9 @@ Resources:
304298
DependsOn:
305299
- VPC
306300
- VPCGatewayAttachment
301+
- VPCCIDRBlock2
302+
- VPCCIDRBlock3
303+
- VPCCIDRBlock4
307304
Metadata:
308305
Comment: Public Subnet 3, https://docs.aws.amazon.com/eks/latest/userguide/alb-ingress.html
309306
Properties:
@@ -379,6 +376,9 @@ Resources:
379376
DependsOn:
380377
- VPC
381378
- VPCGatewayAttachment
379+
- VPCCIDRBlock2
380+
- VPCCIDRBlock3
381+
- VPCCIDRBlock4
382382
Metadata:
383383
Comment: Private Subnet 1
384384
Properties:
@@ -397,6 +397,9 @@ Resources:
397397
DependsOn:
398398
- VPC
399399
- VPCGatewayAttachment
400+
- VPCCIDRBlock2
401+
- VPCCIDRBlock3
402+
- VPCCIDRBlock4
400403
Metadata:
401404
Comment: Private Subnet 2
402405
Properties:

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ replace (
4343
)
4444

4545
require (
46-
github.com/aws/aws-sdk-go v1.35.8
46+
github.com/aws/aws-sdk-go v1.35.10
4747
github.com/briandowns/spinner v1.11.1
4848
github.com/cihub/seelog v0.0.0-20170130134532-f561c5e57575
4949
github.com/davecgh/go-spew v1.1.1

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,8 @@ github.com/auth0/go-jwt-middleware v0.0.0-20170425171159-5493cabe49f7/go.mod h1:
102102
github.com/aws/aws-sdk-go v1.6.10/go.mod h1:ZRmQr0FajVIyZ4ZzBYKG5P3ZqPz9IHG41ZoMu1ADI3k=
103103
github.com/aws/aws-sdk-go v1.15.11/go.mod h1:mFuSZ37Z9YOHbQEwBWztmVzqXrEkub65tZoCYDt7FT0=
104104
github.com/aws/aws-sdk-go v1.28.2/go.mod h1:KmX6BPdI08NWTb3/sm4ZGu5ShLoqVDhKgpiN924inxo=
105-
github.com/aws/aws-sdk-go v1.35.8 h1:+S3BTWePYImKLh7DUJxMVm+/FQUnmHADsMzo/psHFr4=
106-
github.com/aws/aws-sdk-go v1.35.8/go.mod h1:tlPOdRjfxPBpNIwqDj61rmsnA85v9jc0Ps9+muhnW+k=
105+
github.com/aws/aws-sdk-go v1.35.10 h1:FsJtrOS7P+Qmq1rPTGgS/+qC1Y9eGuAJHvAZpZlhmb4=
106+
github.com/aws/aws-sdk-go v1.35.10/go.mod h1:tlPOdRjfxPBpNIwqDj61rmsnA85v9jc0Ps9+muhnW+k=
107107
github.com/bazelbuild/bazel-gazelle v0.18.2/go.mod h1:D0ehMSbS+vesFsLGiD6JXu3mVEzOlfUl8wNnq+x/9p0=
108108
github.com/bazelbuild/bazel-gazelle v0.19.1-0.20191105222053-70208cbdc798/go.mod h1:rPwzNHUqEzngx1iVBfO/2X2npKaT3tqPqqHW6rVsn/A=
109109
github.com/bazelbuild/buildtools v0.0.0-20190731111112-f720930ceb60/go.mod h1:5JP0TXzWDHXv8qvxRC4InIazwdyDseBDbzESUMKk1yU=

vendor/github.com/aws/aws-sdk-go/aws/endpoints/defaults.go

Lines changed: 30 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/aws/aws-sdk-go/aws/version.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/aws/aws-sdk-go/service/ssm/api.go

Lines changed: 11 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/modules.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ github.com/andybalholm/brotli
8484
github.com/armon/circbuf
8585
# github.com/asaskevich/govalidator v0.0.0-20200108200545-475eaeb16496
8686
github.com/asaskevich/govalidator
87-
# github.com/aws/aws-sdk-go v1.35.8
87+
# github.com/aws/aws-sdk-go v1.35.10
8888
## explicit
8989
github.com/aws/aws-sdk-go/aws
9090
github.com/aws/aws-sdk-go/aws/arn

0 commit comments

Comments
 (0)