fix: replace deprecated npm --production with --omit=dev (#553) (#828)

The --production flag is deprecated in npm 8+ and causes warnings that
can be treated as errors. Replace with --omit=dev which is the modern
equivalent, supported in npm 7+.

Co-authored-by: Reed Hamilton <reedham@amazon.com>

Author: sriram-mv

aws_lambda_builders/workflows/nodejs_npm/actions.py

@@ -111,7 +111,7 @@ def execute(self):
         try:
             LOG.debug("NODEJS installing production dependencies in: %s", self.install_dir)
 
-            command = ["install", "-q", "--no-audit", "--no-save", "--unsafe-perm", "--production"]
+            command = ["install", "-q", "--no-audit", "--no-save", "--unsafe-perm", "--omit=dev"]
             self.subprocess_npm.run(command, cwd=self.install_dir)
 
         except NpmExecutionError as ex:
@@ -140,7 +140,7 @@ def execute(self):
                 "--no-audit",
                 "--no-save",
                 "--unsafe-perm",
-                "--production",
+                "--omit=dev",
                 "--no-package-lock",
                 "--install-links",
             ]

aws_lambda_builders/workflows/nodejs_npm_esbuild/DESIGN.md

@@ -26,7 +26,7 @@ operation is designed to be faster than installing dependencies using `npm insta
 in automated CI environments.
 
 If the directory does not contain lockfiles, but contains `package.json`,
-execute [`npm install --production`] to download production dependencies.
+execute [`npm install --omit=dev`] to download production dependencies.
 
 #### Step 2: bundle the main Lambda file
 

tests/unit/workflows/nodejs_npm/test_actions.py

@@ -67,7 +67,7 @@ def test_installs_npm_production_dependencies_for_npm_project(self, SubprocessNp
 
         action.execute()
 
-        expected_args = ["install", "-q", "--no-audit", "--no-save", "--unsafe-perm", "--production"]
+        expected_args = ["install", "-q", "--no-audit", "--no-save", "--unsafe-perm", "--omit=dev"]
 
         subprocess_npm.run.assert_called_with(expected_args, cwd="artifacts")