Skip to content

Commit 8216ad8

Browse files
dkosticclaude
andcommitted
fix(ssl): export ssl_handshake_new and tls12_check_peer_sigalg
The shared-library ssl_test build failed to link against libssl.so because the previous commit's MLDSAHandshakeTest.RejectedByPeerSigalgCheckInTLS12 calls these internal symbols directly. Mark them OPENSSL_EXPORT (along with the SSL_HANDSHAKE ctor/dtor used by UniquePtr) so they are visible in shared builds. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 37704d1 commit 8216ad8

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

ssl/internal.h

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1842,8 +1842,8 @@ struct SSL_HANDSHAKE_HINTS {
18421842
};
18431843

18441844
struct SSL_HANDSHAKE {
1845-
explicit SSL_HANDSHAKE(SSL *ssl);
1846-
~SSL_HANDSHAKE();
1845+
OPENSSL_EXPORT explicit SSL_HANDSHAKE(SSL *ssl);
1846+
OPENSSL_EXPORT ~SSL_HANDSHAKE();
18471847
static constexpr bool kAllowUniquePtr = true;
18481848

18491849
// ssl is a non-owning pointer to the parent |SSL| object.
@@ -2203,7 +2203,7 @@ struct SSL_HANDSHAKE {
22032203
// so many tickets.
22042204
constexpr size_t kMaxTickets = 16;
22052205

2206-
UniquePtr<SSL_HANDSHAKE> ssl_handshake_new(SSL *ssl);
2206+
OPENSSL_EXPORT UniquePtr<SSL_HANDSHAKE> ssl_handshake_new(SSL *ssl);
22072207

22082208
// ssl_check_message_type checks if |msg| has type |type|. If so it returns
22092209
// one. Otherwise, it sends an alert and returns zero.
@@ -2486,8 +2486,9 @@ bool tls12_add_verify_sigalgs(const SSL_HANDSHAKE *hs, CBB *out);
24862486
// tls12_check_peer_sigalg checks if |sigalg| is acceptable for the peer
24872487
// signature. It returns true on success and false on error, setting
24882488
// |*out_alert| to an alert to send.
2489-
bool tls12_check_peer_sigalg(const SSL_HANDSHAKE *hs, uint8_t *out_alert,
2490-
uint16_t sigalg);
2489+
OPENSSL_EXPORT bool tls12_check_peer_sigalg(const SSL_HANDSHAKE *hs,
2490+
uint8_t *out_alert,
2491+
uint16_t sigalg);
24912492

24922493

24932494
// Underdocumented functions.

0 commit comments

Comments
 (0)