Skip to content

Commit 7f33a27

Browse files
authored
should use dockerhub_token (#324)
* should use dockerhub_token * Update Makefile
1 parent 7ec2ce5 commit 7f33a27

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

Makefile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ IMG ?= amazon/aws-node-termination-handler
66
IMG_TAG ?= ${VERSION}
77
IMG_W_TAG = ${IMG}:${IMG_TAG}
88
DOCKER_USERNAME ?= ""
9-
DOCKER_PASSWORD ?= ""
9+
DOCKERHUB_TOKEN ?= ""
1010
GOOS ?= linux
1111
GOARCH ?= amd64
1212
GOPROXY ?= "https://proxy.golang.org,direct"
@@ -35,7 +35,7 @@ docker-run:
3535
docker run ${IMG_W_TAG}
3636

3737
docker-push:
38-
@docker login -u ${DOCKER_USERNAME} -p="${DOCKER_PASSWORD}"
38+
@docker login -u ${DOCKER_USERNAME} -p="${DOCKERHUB_TOKEN}"
3939
docker push ${IMG_W_TAG}
4040

4141
build-docker-images:
@@ -45,11 +45,11 @@ build-docker-images-windows:
4545
${MAKEFILE_PATH}/scripts/build-docker-images -p ${SUPPORTED_PLATFORMS_WINDOWS} -r ${IMG} -v ${VERSION}
4646

4747
push-docker-images:
48-
@docker login -u ${DOCKER_USERNAME} -p="${DOCKER_PASSWORD}"
48+
@docker login -u ${DOCKER_USERNAME} -p="${DOCKERHUB_TOKEN}"
4949
${MAKEFILE_PATH}/scripts/push-docker-images -p ${SUPPORTED_PLATFORMS_LINUX} -r ${IMG} -v ${VERSION} -m
5050

5151
push-docker-images-windows:
52-
@docker login -u ${DOCKER_USERNAME} -p="${DOCKER_PASSWORD}"
52+
@docker login -u ${DOCKER_USERNAME} -p="${DOCKERHUB_TOKEN}"
5353
${MAKEFILE_PATH}/scripts/push-docker-images -p ${SUPPORTED_PLATFORMS_WINDOWS} -r ${IMG} -v ${VERSION} -m
5454

5555
version:
@@ -174,4 +174,4 @@ release-prep-patch: create-local-release-tag-patch create-release-prep-pr
174174
release-prep-custom: # Run make NEW_VERSION=v1.2.3 release-prep-custom to prep for a custom release version
175175
ifdef NEW_VERSION
176176
$(shell echo "${MAKEFILE_PATH}/scripts/create-local-tag-for-release -v $(NEW_VERSION) && echo && make create-release-prep-pr")
177-
endif
177+
endif

0 commit comments

Comments
 (0)