aws-sam-cli/tests/unit/lib/intrinsic_resolver/test_fn_join_with_getatt.py at 996b581adbb2eb1692d3680170a95a22fcd6a293 · aws/aws-sam-cli · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
"""
Unit tests for Fn::Join with Fn::GetAtt bug fix
"""

from unittest import TestCase
from samcli.lib.intrinsic_resolver.intrinsic_property_resolver import IntrinsicResolver
from samcli.lib.intrinsic_resolver.intrinsics_symbol_table import IntrinsicsSymbolTable


class TestFnJoinWithGetAtt(TestCase):
    """
    Test that Fn::Join works correctly with Fn::GetAtt for Lambda function ARNs,
    especially when the FunctionName property contains intrinsic functions.
    """

    def test_fn_join_with_getatt_simple_function_name(self):
        """
        Test Fn::Join with Fn::GetAtt when FunctionName is a simple string
        """
        template = {
            "Resources": {
                "MyFunction": {
                    "Type": "AWS::Lambda::Function",
                    "Properties": {
                        "FunctionName": "my-function-name",
                    },
                }
            }
        }

        resolver = IntrinsicResolver(
            template=template, symbol_resolver=IntrinsicsSymbolTable(logical_id_translator={}, template=template)
        )

        uri_intrinsic = {
            "Fn::Join": [
                "",
                [
                    "arn:",
                    {"Ref": "AWS::Partition"},
                    ":apigateway:",
                    {"Ref": "AWS::Region"},
                    ":lambda:path/2015-03-31/functions/",
                    {"Fn::GetAtt": ["MyFunction", "Arn"]},
                    "/invocations",
                ],
            ]
        }

        result = resolver.intrinsic_property_resolver(uri_intrinsic, ignore_errors=False)

        self.assertIsInstance(result, str)
        self.assertIn("my-function-name", result)
        self.assertIn("arn:aws:apigateway:", result)
        self.assertIn("lambda:path/2015-03-31/functions/", result)
        self.assertIn("/invocations", result)

    def test_fn_join_with_getatt_intrinsic_function_name(self):
        """
        Test Fn::Join with Fn::GetAtt when FunctionName contains Fn::Sub
        This was the original bug - it would throw TypeError: unhashable type: 'dict'
        """
        template = {
            "Resources": {
                "MyFunction": {
                    "Type": "AWS::Lambda::Function",
                    "Properties": {
                        "FunctionName": {"Fn::Sub": "my-${AWS::StackName}-function"},
                    },
                }
            }
        }

        resolver = IntrinsicResolver(
            template=template, symbol_resolver=IntrinsicsSymbolTable(logical_id_translator={}, template=template)
        )

        uri_intrinsic = {
            "Fn::Join": [
                "",
                [
                    "arn:",
                    {"Ref": "AWS::Partition"},
                    ":apigateway:",
                    {"Ref": "AWS::Region"},
                    ":lambda:path/2015-03-31/functions/",
                    {"Fn::GetAtt": ["MyFunction", "Arn"]},
                    "/invocations",
                ],
            ]
        }

        result = resolver.intrinsic_property_resolver(uri_intrinsic, ignore_errors=False)

        self.assertIsInstance(result, str)
        self.assertIn("MyFunction", result)
        self.assertIn("arn:aws:apigateway:", result)
        self.assertIn("lambda:path/2015-03-31/functions/", result)
        self.assertIn("/invocations", result)

    def test_fn_join_with_getatt_no_function_name(self):
        """
        Test Fn::Join with Fn::GetAtt when FunctionName property is not defined
        Should use the logical ID as the function name
        """
        template = {
            "Resources": {
                "MyFunction": {
                    "Type": "AWS::Lambda::Function",
                }
            }
        }

        resolver = IntrinsicResolver(
            template=template, symbol_resolver=IntrinsicsSymbolTable(logical_id_translator={}, template=template)
        )

        uri_intrinsic = {
            "Fn::Join": [
                "",
                [
                    "arn:",
                    {"Ref": "AWS::Partition"},
                    ":apigateway:",
                    {"Ref": "AWS::Region"},
                    ":lambda:path/2015-03-31/functions/",
                    {"Fn::GetAtt": ["MyFunction", "Arn"]},
                    "/invocations",
                ],
            ]
        }

        result = resolver.intrinsic_property_resolver(uri_intrinsic, ignore_errors=False)

        self.assertIsInstance(result, str)
        self.assertIn("MyFunction", result)
        self.assertIn("arn:aws:apigateway:", result)
        self.assertIn("lambda:path/2015-03-31/functions/", result)
        self.assertIn("/invocations", result)

    def test_fn_sub_still_works_with_getatt(self):
        """
        Ensure that the fix doesn't break Fn::Sub with Fn::GetAtt (which was already working)
        """
        template = {
            "Resources": {
                "MyFunction": {
                    "Type": "AWS::Lambda::Function",
                    "Properties": {
                        "FunctionName": {"Fn::Sub": "my-${AWS::StackName}-function"},
                    },
                }
            }
        }

        resolver = IntrinsicResolver(
            template=template, symbol_resolver=IntrinsicsSymbolTable(logical_id_translator={}, template=template)
        )

        uri_intrinsic = {
            "Fn::Sub": "arn:aws:apigateway:${AWS::Region}:lambda:path/2015-03-31/functions/${MyFunction.Arn}/invocations"
        }

        result = resolver.intrinsic_property_resolver(uri_intrinsic, ignore_errors=False)

        self.assertIsInstance(result, str)
        self.assertIn("MyFunction", result)
        self.assertIn("arn:aws:apigateway:", result)
        self.assertIn("lambda:path/2015-03-31/functions/", result)
        self.assertIn("/invocations", result)