no-fail-on-empty-changeset parameter not getting saved to samconfig.toml or mapped to deploy

[singledigit]

Description

When passing the --no-fail-on-empty-changeset flag in sam deploy -g, the parameter does not get saved to the samconfig.toml file. It also does not get passed in the deploy or have any affect. In #1657 this is talked about and the solution was to manually add it to the template. However, as of v1.6.2 this doesn't seem to work. I tried both no-fail-on-empty-changeset=true and fail-on-empty-changeset=false. No joy on either options.

Steps to reproduce

1. in project run sam deploy -g --no-fail-on-empty-changeset

Observed result

Try 'sam deploy --help' for help.

Error: no such option: --no-fail-on-empty-changese  Did you mean --no-fail-on-empty-changeset?

Expected result

I expected the build to work even if no changes were found. I also expected the parameter to be saved in the samconfig.toml file for later builds

Additional environment details (Ex: Windows, Mac, Amazon Linux etc)

1. OS: Mac and Linux
2. sam --version: 1.6.2

Add --debug flag to command you are running

[hawflau]

@singledigit Can you try fail_on_empty_changeset=false? note that - should be replaced with _

[hawflau]

Also, only the listed parameters listed in this section are saved into samconfig.toml when you run sam deploy -g.
If you manually add fail_on_empty_changeset = false into samconfig.toml, it will be respected the next time you run sam deploy or sam deploy -g.

Hope that solves your problem.

[aprilmintacpineda]

fail_on_empty_changeset=false works for me.

[Shahid1993]

Facing the same issue as I can't deploy the stack if no changes are found. Neither --no-fail-on-empty-changeset nor the suggested fail_on_empty_changeset=false work for me.

For the use cases where container images are used for lambda functions, this feature becomes quite critical, as quite often only the container image is updated, without any change to the stack.