Skip to content

Proxy settings not passed through s3-crt #2571

@ZacTurnerHPE

Description

@ZacTurnerHPE

Describe the bug

When setting proxy settings (proxyScheme, proxyHost, proxyPort etc) in Aws::S3Crt::ClientConfiguration and passing these through to a new instance of Aws::S3Crt::S3CrtClient the proxy is used for most operations, but is ignored for operations passed through to crt (get, put).

Expected Behavior

Proxy should be used for all operations

Current Behavior

Proxy is used for the majority of operations, but is not passed through to crt for GET and PUT. For these operations the system proxy (HTTPS_PROXY env) is used instead if set.

Reproduction Steps

Create an instance of Aws::S3Crt::S3CrtClient with proxy set and attempt GET/PUTs

Possible Solution

In S3CrtClient::init other config options are passed through to aws_s3_client_config s3CrtConfig, including tcp and credentials settings, but with no mention of proxy. Hard coding a proxy here seems to make it work for crt operations.

Additional Information/Context

No response

AWS CPP SDK version used

1.11.115

Compiler and Version used

gcc 11.3.1

Operating System and version

Rocky Linux 9

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature-requestA feature should be added or improved.p3This is a minor priority issue

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions