Skip to content

Missing includes #3002

Open
Open
@laramiel

Description

@laramiel

Describe the bug

I am working on bazel build rules for some aws sdk libraries; bazel is more strict about includes than cmake.
These files are missing includes, which causes errors.

  • aws-cpp-sdk-core/include/aws/core/NoResult.h
  • aws-cpp-sdk-core/include/aws/core/utils/stream/StreamBufProtectedWriter.h
  • aws-cpp-sdk-core/include/aws/core/monitoring/MonitoringFactory.h
  • aws-cpp-sdk-core/include/aws/core/Globals.h
  • aws-cpp-sdk-core/include/aws/core/utils/event/EventStreamEncoder.h

Expected Behavior

No errors.

Current Behavior

Errors on missing includes.

Reproduction Steps

Add BUILD.bazel rules and build.

Possible Solution

  • aws-cpp-sdk-core/include/aws/core/NoResult.h
#include <aws/core/AmazonWebServiceResult.h>
  • aws-cpp-sdk-core/include/aws/core/utils/stream/StreamBufProtectedWriter.h
#include <cstdint>
#include <aws/core/utils/memory/stl/AWSStreamFwd.h>
#include <aws/core/utils/logging/LogMacros.h>
  • aws-cpp-sdk-core/include/aws/core/monitoring/MonitoringFactory.h
include <aws/core/utils/memory/AWSMemory.h>
  • aws-cpp-sdk-core/include/aws/core/Globals.h
#include <memory>
  • aws-cpp-sdk-core/include/aws/core/utils/event/EventStreamEncoder.h
#include <aws/core/utils/memory/stl/AWSString.h>
#include <aws/core/utils/event/EventMessage.h>

Additional Information/Context

No response

AWS CPP SDK version used

67f1aae

Compiler and Version used

clang

Operating System and version

linux

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugThis issue is a bug.build-problemproblems with building this sdkp3This is a minor priority issuepending-releaseThis issue will be fixed by an approved PR that hasn't been released yet.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions