Skip to content

Commit 09f35b4

Browse files
authored
backfill @required on imagebuilder#LaunchTemplateConfiguration.SetDefaultVersion (#2838)
1 parent 04e7aca commit 09f35b4

File tree

6 files changed

+19
-7
lines changed

6 files changed

+19
-7
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
{
2+
"id": "139b04a8-d612-4cb2-9dfb-9e66f9f70386",
3+
"type": "bugfix",
4+
"description": "**BREAKING CHANGE**: The type of LaunchTemplateConfiguration.SetDefaultVersion has been changed from `bool` to `*bool`. Before this change, the field was incorrectly marked as having a default value of false by the service, which made it functionally impossible for users to express the full range of values for the field (true, false, and unset/nil), each of which have distinctly different behaviors.",
5+
"modules": [
6+
"service/imagebuilder"
7+
]
8+
}

codegen/smithy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/customization/BackfillRequiredTrait.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,4 +54,4 @@ private static Map.Entry<ShapeId, Set<ShapeId>> serviceToShapeIds(String service
5454
ShapeId.from(serviceId),
5555
Arrays.stream(shapeIds).map(ShapeId::from).collect(toSet()));
5656
}
57-
}
57+
}

codegen/smithy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/customization/RemoveDefaults.java

+6-2
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,11 @@ public class RemoveDefaults implements GoIntegration {
3232
serviceToShapeIds("com.amazonaws.paymentcryptographydata#PaymentCryptographyDataPlane",
3333
"com.amazonaws.paymentcryptographydata#IntegerRangeBetween4And12"),
3434
serviceToShapeIds("com.amazonaws.emrserverless#AwsToledoWebService",
35-
"com.amazonaws.emrserverless#WorkerCounts"));
35+
"com.amazonaws.emrserverless#WorkerCounts"),
36+
serviceToShapeIds("com.amazonaws.imagebuilder#imagebuilder",
37+
// https://github.com/aws/aws-sdk-go-v2/issues/2734
38+
// V1479153907
39+
"com.amazonaws.imagebuilder#LaunchTemplateConfiguration$setDefaultVersion"));
3640

3741
private boolean mustPreprocess(ShapeId service) {
3842
return toRemove.containsKey(service);
@@ -95,4 +99,4 @@ private static Map.Entry<ShapeId, Set<ShapeId>> serviceToShapeIds(String service
9599
ShapeId.from(serviceId),
96100
Arrays.stream(shapeIds).map(ShapeId::from).collect(Collectors.toSet()));
97101
}
98-
}
102+
}

service/imagebuilder/deserializers.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

service/imagebuilder/serializers.go

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

service/imagebuilder/types/types.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)