`Release 2024-12-23` change to `ecrpublic` service breaks client endpoint resolution contract

[ewbankkit]

Acknowledgements

• I have searched (https://github.com/aws/aws-sdk/issues?q=is%3Aissue) for past instances of this issue
• I have verified all of my SDK modules are up-to-date (you can perform a bulk update with go get -u github.com/aws/aws-sdk-go-v2/...)

Describe the bug

Changes to the ecrpublic service in Release 2024-12-23, in particular this commit, have broken the client endpoint resolution contract described here -- the ecrpublic.EndpointParameters.Endpoint field has been removed.
This is a breaking change for code that was written to this contract.

Regression Issue

• Select this option if this issue appears to be a regression.

Expected Behavior

Code using ecrpublic.EndpointParameters.Endpoint compiles.

Current Behavior

Code using ecrpublic.EndpointParameters.Endpoint fails to compile.

Reproduction Steps

See https://github.com/hashicorp/terraform-provider-aws/blob/65947b9e5111a6cc7cfdf7860a2187e76de9c27a/internal/service/ecrpublic/service_endpoint_resolver_gen.go#L29-L74:

func (r resolverV2) ResolveEndpoint(ctx context.Context, params ecrpublic.EndpointParameters) (endpoint smithyendpoints.Endpoint, err error) {
	params = params.WithDefaults()
	useFIPS := aws.ToBool(params.UseFIPS)

	if eps := params.Endpoint; aws.ToString(eps) != "" {

Possible Solution

n/a

Additional Information/Context

No response

AWS Go SDK V2 Module Versions Used

% grep ecrpublic go.mod 
	github.com/aws/aws-sdk-go-v2/service/ecrpublic v1.28.0

Compiler and Version used

go version go1.23.3 darwin/arm64

Operating System and version

macos

[RanVaknin]

Hi @ewbankkit ,

Thanks for reaching out. We are aware of this issue. ECR has indeed released a something that was a breaking change. We are working on mitigating this with priority.

Please stay tuned.

Thanks,
Ran~

[ewbankkit]

It looks like this was fixed (Endpoints was restored) in dfd84e5, Release 2024-12-28.

[github-actions]

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.