Skip to content

Commit 05b96f5

Browse files
committed
Address PR feedback
1 parent 6080eb8 commit 05b96f5

2 files changed

Lines changed: 2 additions & 0 deletions

File tree

services/s3/src/main/java/software/amazon/awssdk/services/s3/S3Utilities.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -442,6 +442,7 @@ private ClientEndpointProvider clientEndpointProvider(URI overrideEndpoint, Regi
442442

443443
return resolvedOverride
444444
.map(uri -> ClientEndpointProvider.create(uri, true))
445+
// Need an endpoint to marshall but this will be overwritten in modifyHttpRequest
445446
.orElseGet(() -> ClientEndpointProvider.create(URI.create("https://localhost"), false));
446447
}
447448

services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/signing/DefaultS3Presigner.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -274,6 +274,7 @@ private SdkClientConfiguration createClientConfiguration() {
274274
+ testEndpoint + ". This is usually caused by an invalid region "
275275
+ "configuration.");
276276
}
277+
// Need an endpoint to marshall but this will be overwritten in modifyHttpRequest
277278
endpointProvider = ClientEndpointProvider.create(URI.create("https://localhost"), false);
278279
}
279280

0 commit comments

Comments
 (0)