Removing numattempts larger than 0 valiadations

Author: RanVaknin

core/aws-core/src/main/java/software/amazon/awssdk/awscore/exception/AwsServiceException.java

@@ -74,7 +74,7 @@ public String getMessage() {
             joiner.add(serviceDiagnostics());
         }
 
-        if (numAttempts() != null && numAttempts() > 0) {
+        if (numAttempts() != null) {
             SdkDiagnostics diagnostics = SdkDiagnostics.builder().numAttempts(numAttempts()).build();
             joiner.add(diagnostics.toString());
         }

core/aws-core/src/test/java/software/amazon/awssdk/awscore/exception/AwsServiceExceptionTest.java

@@ -113,6 +113,9 @@ private static Stream<Arguments> exceptionMessageTestCases() {
             Arguments.of(
                 3,
                 "errorMessage (Service: serviceName, Status Code: 500, Request ID: requestId) (SDK Attempt Count: 3)"),
+            Arguments.of(
+                0,
+                "errorMessage (Service: serviceName, Status Code: 500, Request ID: requestId) (SDK Attempt Count: 0)"),
             Arguments.of(
                 null,
                 "errorMessage (Service: serviceName, Status Code: 500, Request ID: requestId)")

core/sdk-core/src/main/java/software/amazon/awssdk/core/exception/SdkClientException.java

@@ -50,7 +50,7 @@ public static SdkClientException create(String message, Throwable cause) {
     @Override
     public String getMessage() {
         String message = rawMessage();
-        if (numAttempts() != null && numAttempts() > 0) {
+        if (numAttempts() != null) {
             SdkDiagnostics sdkDiagnostics = SdkDiagnostics.builder().numAttempts(numAttempts()).build();
             message = message + " " + sdkDiagnostics;
         }

core/sdk-core/src/main/java/software/amazon/awssdk/core/exception/SdkDiagnostics.java

@@ -35,7 +35,7 @@ public static Builder builder() {
     @Override
     public String toString() {
         StringJoiner details = new StringJoiner(", ", "(", ")");
-        if (numAttempts != null && numAttempts > 0) {
+        if (numAttempts != null) {
             details.add("SDK Attempt Count: " + numAttempts);
             return details.toString();
         }