Commit af146f4
Rishabh Jain
fix(s3): preserve original cause in ParallelMultipartDownloaderSubscriber.onError
onError cancelled in-flight part requests before completing resultFuture with
the failure cause. The cancel loop races a CancellationException onto
resultFuture (via the forwardExceptionTo wiring), so callers observing the
download's completion future saw a bare CancellationException with no root
cause. The trigger was also never logged.
Complete resultFuture with the original throwable first, then cancel, and log
the cause at debug level, matching the sibling
ParallelPresignedUrlMultipartDownloaderSubscriber.1 parent f3ea4fc commit af146f4
2 files changed
Lines changed: 10 additions & 4 deletions
File tree
- .changes/next-release
- services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/multipart
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
412 | 412 | | |
413 | 413 | | |
414 | 414 | | |
415 | | - | |
416 | | - | |
417 | | - | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
418 | 419 | | |
419 | 420 | | |
420 | | - | |
421 | 421 | | |
422 | 422 | | |
423 | 423 | | |
| |||
0 commit comments