Setting maxAttempts to 1

[brycechesternewman]

Hi,
I am using 2.26.0. I want to be able to set the maxAttemts to 1 via the API. I know how to do this via jvm property, but am unsure of how to do this in code.

Is there a better type safe way to set maxAttemts to 1?

val retryStrategy: RetryStrategy = ClientOverrideConfiguration.builder().retryStrategy(RetryMode.STANDARD).retryStrategy()
val mutatedRetryStrategy = retryStrategy.toBuilder.maxAttempts(1)
S3AsyncClient.builder().overrideConfiguration(ClientOverrideConfiguration.builder().retryStrategy(mutatedRetryStrategy).build())
....

[sugmanue]

Hi @brycechesternewman,

What you're doing works fine in Java. Can you elaborate on what issues you're getting?.

Note that setting maxAttempts to 1 is equivalent to disabling retries, for that you can use AwsRetryStrategy.doNotRetry(), e.g.,

ClientOverrideConfiguration.builder().retryStrategy(AwsRetryStrategy.doNotRetry())

You can also use the more functional way of .overrideConfiguration(Consumer<OverrideConfiguration.Builder>), (see here), e.g.,

S3AsyncClient.builder().overrideConfiguration(o -> o.retryStrategy(AwsRetryStrategy.doNotRetry()).build()

Or even

S3AsyncClient.builder().overrideConfiguration(o -> o.retryStrategy(b -> b.maxAttempts(1)).build()

See here and here.

[brycechesternewman]

Thank you for the response. Yah. The behavior I want is to not retry. Why not retry?
In version 2.25.56 we randomly and in rare cases see this exception.

 cause:  Exception in thread "zio-fiber-" software.amazon.awssdk.core.exception.NonRetryableException: A retry was attempted, but AsyncRequestBody.split does not support retries.
	at software.amazon.awssdk.core.exception.NonRetryableException$BuilderImpl.build(NonRetryableException.java:109)
	at software.amazon.awssdk.core.exception.NonRetryableException.create(NonRetryableException.java:49)
	at software.amazon.awssdk.core.internal.async.SplittingPublisher$SplittingSubscriber$DownstreamBody.subscribe(SplittingPublisher.java:296)
	at software.amazon.awssdk.core.internal.async.ChecksumCalculatingAsyncRequestBody.lambda$alwaysInvokeOnNext$2(ChecksumCalculatingAsyncRequestBody.java:160)
	at software.amazon.awssdk.core.async.SdkPublisher.lambda$map$1(SdkPublisher.java:86)
	at software.amazon.awssdk.core.async.SdkPublisher.lambda$flatMapIterable$2(SdkPublisher.java:97)
	at software.amazon.awssdk.core.internal.async.ChecksumCalculatingAsyncRequestBody.subscribe(ChecksumCalculatingAsyncRequestBody.java:156)
	at software.amazon.awssdk.core.internal.http.pipeline.stages.MakeAsyncHttpRequestStage$SdkHttpContentPublisherAdapter.subscribe(MakeAsyncHttpRequestStage.java:279)
	at software.amazon.awssdk.http.nio.netty.internal.NettyRequestExecutor$StreamedRequest.subscribe(NettyRequestExecutor.java:431)
	at software.amazon.awssdk.http.nio.netty.internal.nrs.HttpStreamsHandler.subscribeSubscriberToStream(HttpStreamsHandler.java:139)
	at software.amazon.awssdk.http.nio.netty.internal.nrs.HttpStreamsClientHandler.channelRead(HttpStreamsClientHandler.java:150)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:442)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412)
	at io.netty.handler.logging.LoggingHandler.channelRead(LoggingHandler.java:280)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:442)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412)
	at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:289)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:442)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412)
	at io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelRead(CombinedChannelDuplexHandler.java:436)
	at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:346)
	at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:318)
	at io.netty.channel.CombinedChannelDuplexHandler.channelRead(CombinedChannelDuplexHandler.java:251)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:442)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412)
	at io.netty.handler.ssl.SslHandler.unwrap(SslHandler.java:1475)
	at io.netty.handler.ssl.SslHandler.decodeJdkCompatible(SslHandler.java:1338)
	at io.netty.handler.ssl.SslHandler.decode(SslHandler.java:1387)
	at io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:529)
	at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:468)
	at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:290)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412)
	at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:289)
	at software.amazon.awssdk.http.nio.netty.internal.OneTimeReadTimeoutHandler.channelRead(OneTimeReadTimeoutHandler.java:37)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:442)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412)
	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420)
	at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
	at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166)
	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:788)
	at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:724)
	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:650)
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:562)
	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
	at java.base/java.lang.Thread.run(Thread.java:833)

When exception occurs the thread hangs - which could be an issue with ZIO threads or just a new issue with the AWS SDK. I don't have a fiber dump from ZIO or java yet to prove what is hanging, so in the mean time not retrying to see if the problem goes away.

AwsRetryStrategy.doNotRetry() is likely the option I was looking for. Thank you.
I also found that this would work for overriding max attempt for other strategies.

     val adaptiveRetryStrategy = StandardRetryStrategy.builder().maxAttempts(1).build()
      S3AsyncClient.builder()
        .overrideConfiguration(ClientOverrideConfiguration.builder().retryStrategy(adaptiveRetryStrategy).build())

[brycechesternewman]

I will open up a new thread on "software.amazon.awssdk.core.exception.NonRetryableException: A retry was attempted, but AsyncRequestBody.split does not support retries." Thanks for a reply to my original question.