Use environment variables to configure HTTP proxies

[kgregory-chariot]

Describe the feature

The V1 Java SDK and others use the environment variables PROXY_HTTP and PROXY_HTTPs to configure a proxy. The v2 SDK only allows system properties.

There was already request to add this, but it was incorrectly closed by the PR that supported system properties (and I see that there's an outstanding issue that would have been solved by that PR, so perhaps the wrong issue was closed?)

Is your Feature Request related to a problem?

This means that you can't use a consistent deployment approach for deploying AWS applications in a polyglot environment. Or you have to write explicit code in your Java v2 SDK projects to retrieve the relevant environment variables and set system properties, before anything else happens in the program.

Proposed Solution

Update ProxyConfiguration.java for all three HTTP client implementations to look for environment variables as well as system properties.

Describe alternatives you've considered

Not using the v2 SDK is the simplest.

Otherwise, as mentioned above, writing explicit code to set the system properties from the value of the environment variables (because Lambda doesn't let you set system properties when the JVM is first run).

Acknowledge

• I may be able to implement this feature request

AWS Java SDK version used

2.17.101

JDK version used

openjdk version "11.0.13" 2021-10-19

Operating System and version

Ubuntu 20.04

[debora-ito]

@kgregory-chariot sorry for the confusion 😓 yes, it seems that environment variables are not supported yet.

#1334 was not addressed by the PR #2771 either, the ask is to support HTTPS system properties.

Let's use this issue to track the support for PROXY_HTTP and PROXY_HTTPS environment variables.

[kgregory-chariot]

As a comment on #2771: the approach that it took was to use the same set of system properties for all proxies. Which is perhaps reasonable, as I believe that the v2 SDK doesn't make non-TLS connections? However, the naming of those properties is inconsistent with the convention used in v1.

[haslam22]

+1 would be really nice to see this implemented. It's a real pain to have to look up https_proxy and http_proxy environment variables, parse the username/password/host/port out of them, and then provide those to SDK v2 manually when creating a client. This was implemented nicely in SDK v1 in this pull request: aws/aws-sdk-java#1967 and almost makes me want to downgrade to use that functionality.

[patrickgombert]

Any updates here? It would be great to have this feature added.

[haslam22]

@debora-ito Would it be reasonable for me to start working on this and open up a pull request so we can get this v1 functionality into v2? Just checking because this was raised a while ago and I want to double check it's still valid and appropriate to be worked on. Thanks

[unoexperto]

I don't know if it's bug or feature but environmentVariable() of software.amazon.awssdk.utils.ProxySystemSetting returns null thus fallback mechanism in SystemSettingUtils.resolveSetting() is not working.

For now I just added this on start of my app but it's kinda a hack:

// Copy proxy settings from system env to VM env.
for (key in software.amazon.awssdk.utils.ProxySystemSetting.values()) {
    val value = System.getenv(key.property())
    if (value != null)
        System.setProperty(key.property(), value)
}

[maslakov]

Hi! Is there any progress on this? @haslam22 why have you closed your PR?
This is a real pain now! All software and frameworks understand http[s]_proxy env variables but AWS SDK v2.