Preserve contentLength for InMemoryPublisher#7141
Open
davidh44 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Follow up to #7129
After fixing the
InMemoryPublisherdeadlock,InMemoryPublisherstill reports nocontentLength()because it only implements barePublisher<ByteBuffer>. This means the CRT HTTP client receivesgetLength()=0("unknown length"). Additionally,FlexibleChecksummerhas a theoretical race condition where checksum headers could be set after signing due to a detachedthenRunside-effect.When
InMemoryPublishercorrectly reports its content length, a latent bug inMakeAsyncHttpRequestStageis exposed: it addsContent-Lengtheven whenTransfer-Encoding: chunkedis already present, violating RFC 7230 §3.3.2.These are not customer-facing bugs today: CRT handles
getLength()=0correctly and the race condition only manifests with async body sources. This PR is defensive hardening to prevent future issues.Modifications
Checksum computation (
http-auth-aws)FlexibleChecksummer— Replace detachedthenRunwiththenApplyto guarantee checksum headers are set before signing proceeds. Theoretical race condition fix — prevents issues if the body source delivers asynchronously.ChecksumSubscriber— Compute total buffered bytes inonComplete()and pass toInMemoryPublisher.InMemoryPublisher— ImplementSdkHttpContentPublisherto reportcontentLength().Signing (
sdk-core)AsyncSigningStage— PreservecontentLength()when wrappingSdkHttpContentPublisherpayload intoAsyncRequestBody, instead of always usingfromPublisher()which loses it.HTTP request construction (
sdk-core)MakeAsyncHttpRequestStage— Don't setContent-LengthifTransfer-Encodingis already present. These are mutually exclusive per RFC 7230 §3.3.2.Testing
Added unit tests, updated TCK test
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License