chore: use isolatedModules for types

Author: kuhe

.eslintrc.js

@@ -8,7 +8,7 @@ module.exports = {
     // Uses the recommended rules from the @typescript-eslint/eslint-plugin
     "plugin:@typescript-eslint/recommended",
   ],
-  plugins: ["@typescript-eslint", "simple-import-sort", "eslint-plugin-sort-export-all", "eslint-plugin-tsdoc", "n"],
+  plugins: ["@typescript-eslint", "simple-import-sort", "eslint-plugin-tsdoc", "n"],
   rules: {
     /** Turn off strict enforcement */
     "@typescript-eslint/ban-types": "off",
@@ -27,7 +27,6 @@ module.exports = {
 
     /** Errors */
     "simple-import-sort/imports": "error",
-    "sort-export-all/sort-export-all": "error",
     "@typescript-eslint/consistent-type-imports": "error",
     "n/prefer-node-protocol": "error",
   },
@@ -50,6 +49,13 @@ module.exports = {
         "private/*/src/**/*.ts",
       ],
       rules: {
+        "no-restricted-syntax": [
+          "error",
+          {
+            selector: "ExportAllDeclaration",
+            message: "Use explicit named exports (export { X } or export type { X }) instead of 'export *'.",
+          },
+        ],
         "no-restricted-imports": [
           "error",
           {
@@ -191,5 +197,15 @@ module.exports = {
         "n/prefer-node-protocol": "error",
       },
     },
+    {
+      files: [
+        "packages-internal/nested-clients/src/submodules/**/index.ts",
+        "packages-internal/nested-clients/src/submodules/**/commands/index.ts",
+        "clients/*/src/**/*.ts",
+      ],
+      rules: {
+        "no-restricted-syntax": "off",
+      },
+    },
   ],
 };

lib/lib-dynamodb/tsconfig.types.json

@@ -5,7 +5,8 @@
     "rootDir": "src",
     "paths": {
       "@smithy/core/*": ["../../node_modules/@smithy/core/dist-types/submodules/*/index.d.ts"]
-    }
+    },
+    "isolatedModules": false
   },
   "extends": "../../tsconfig.types.json",
   "include": ["src/"]

lib/lib-storage/src/index.ts

@@ -1,2 +1,3 @@
-export * from "./Upload";
-export * from "./types";
+export { Upload } from "./Upload";
+export type { RawDataPart } from "./Upload";
+export type { Progress, BodyDataTypes, ServiceClients, Configuration, Options } from "./types";

packages-internal/core/src/api-extractor-type-index.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-syntax */
 export * from "./submodules/account-id-endpoint/index";
 export * from "./submodules/client/index";
 export * from "./submodules/httpAuthSchemes/index";

packages-internal/core/src/submodules/account-id-endpoint/index.ts

@@ -1,3 +1,16 @@
-export * from "./AccountIdEndpointModeConfigResolver";
-export * from "./AccountIdEndpointModeConstants";
-export * from "./NodeAccountIdEndpointModeConfigOptions";
+export { resolveAccountIdEndpointModeConfig } from "./AccountIdEndpointModeConfigResolver";
+export type {
+  AccountIdEndpointModeInputConfig,
+  AccountIdEndpointModeResolvedConfig,
+} from "./AccountIdEndpointModeConfigResolver";
+export {
+  DEFAULT_ACCOUNT_ID_ENDPOINT_MODE,
+  ACCOUNT_ID_ENDPOINT_MODE_VALUES,
+  validateAccountIdEndpointMode,
+} from "./AccountIdEndpointModeConstants";
+export type { AccountIdEndpointMode } from "./AccountIdEndpointModeConstants";
+export {
+  ENV_ACCOUNT_ID_ENDPOINT_MODE,
+  CONFIG_ACCOUNT_ID_ENDPOINT_MODE,
+  NODE_ACCOUNT_ID_ENDPOINT_MODE_CONFIG_OPTIONS,
+} from "./NodeAccountIdEndpointModeConfigOptions";

packages-internal/core/src/submodules/client/index.browser.ts

@@ -65,16 +65,15 @@ export {
 } from "./util-endpoints/lib/aws/partition";
 export type { PartitionsInfo } from "./util-endpoints/lib/aws/partition";
 export { EndpointError } from "./util-endpoints/types/EndpointError";
-export {
+export type {
   EndpointObjectProperties,
   EndpointObjectHeaders,
   EndpointObject,
-  EndpointRuleObject,
 } from "./util-endpoints/types/EndpointRuleObject";
-export { ErrorRuleObject } from "./util-endpoints/types/ErrorRuleObject";
-export { RuleSetRules, TreeRuleObject } from "./util-endpoints/types/TreeRuleObject";
-export { DeprecatedObject, ParameterObject, RuleSetObject } from "./util-endpoints/types/RuleSetObject";
-export {
+export type { ErrorRuleObject } from "./util-endpoints/types/ErrorRuleObject";
+export type { RuleSetRules } from "./util-endpoints/types/TreeRuleObject";
+export type { DeprecatedObject, ParameterObject } from "./util-endpoints/types/RuleSetObject";
+export type {
   ReferenceObject,
   FunctionObject,
   FunctionArgv,

packages-internal/core/src/submodules/client/index.native.ts

@@ -66,16 +66,15 @@ export {
 } from "./util-endpoints/lib/aws/partition";
 export type { PartitionsInfo } from "./util-endpoints/lib/aws/partition";
 export { EndpointError } from "./util-endpoints/types/EndpointError";
-export {
+export type {
   EndpointObjectProperties,
   EndpointObjectHeaders,
   EndpointObject,
-  EndpointRuleObject,
 } from "./util-endpoints/types/EndpointRuleObject";
-export { ErrorRuleObject } from "./util-endpoints/types/ErrorRuleObject";
-export { RuleSetRules, TreeRuleObject } from "./util-endpoints/types/TreeRuleObject";
-export { DeprecatedObject, ParameterObject, RuleSetObject } from "./util-endpoints/types/RuleSetObject";
-export {
+export type { ErrorRuleObject } from "./util-endpoints/types/ErrorRuleObject";
+export type { RuleSetRules } from "./util-endpoints/types/TreeRuleObject";
+export type { DeprecatedObject, ParameterObject } from "./util-endpoints/types/RuleSetObject";
+export type {
   ReferenceObject,
   FunctionObject,
   FunctionArgv,

packages-internal/core/src/submodules/client/index.ts

@@ -69,16 +69,15 @@ export {
 export type { PartitionsInfo } from "./util-endpoints/lib/aws/partition";
 // util-endpoints types (re-exports from @smithy/core/endpoints)
 export { EndpointError } from "./util-endpoints/types/EndpointError";
-export {
+export type {
   EndpointObjectProperties,
   EndpointObjectHeaders,
   EndpointObject,
-  EndpointRuleObject,
 } from "./util-endpoints/types/EndpointRuleObject";
-export { ErrorRuleObject } from "./util-endpoints/types/ErrorRuleObject";
-export { RuleSetRules, TreeRuleObject } from "./util-endpoints/types/TreeRuleObject";
-export { DeprecatedObject, ParameterObject, RuleSetObject } from "./util-endpoints/types/RuleSetObject";
-export {
+export type { ErrorRuleObject } from "./util-endpoints/types/ErrorRuleObject";
+export type { RuleSetRules } from "./util-endpoints/types/TreeRuleObject";
+export type { DeprecatedObject, ParameterObject } from "./util-endpoints/types/RuleSetObject";
+export type {
   ReferenceObject,
   FunctionObject,
   FunctionArgv,

packages-internal/core/src/submodules/client/util-endpoints/types/EndpointRuleObject.ts

@@ -1,4 +1,4 @@
-export {
+export type {
   EndpointObjectProperties,
   EndpointObjectHeaders,
   EndpointObject,

packages-internal/core/src/submodules/client/util-endpoints/types/ErrorRuleObject.ts

@@ -1 +1 @@
-export { ErrorRuleObject } from "@smithy/core/endpoints";
+export type { ErrorRuleObject } from "@smithy/core/endpoints";