Skip to content

Commit a5fb0db

Browse files
committed
chore(core): update clock skew detection threshold to 4 minutes
1 parent 7d34e3b commit a5fb0db

4 files changed

Lines changed: 10 additions & 10 deletions

File tree

packages-internal/core/src/submodules/httpAuthSchemes/utils/isClockSkewed.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,15 @@ describe(isClockSkewed.name, () => {
1818
vi.clearAllMocks();
1919
});
2020

21-
describe("returns true for time difference >=300000", () => {
22-
it.each([300000, 500000])("difference: %d", (difference) => {
21+
describe("returns true for time difference >=240000", () => {
22+
it.each([240000, 500000])("difference: %d", (difference) => {
2323
expect(isClockSkewed(mockSkewCorrectedDate.getTime() + difference, mockSystemClockOffset)).toBe(true);
2424
expect(isClockSkewed(mockSkewCorrectedDate.getTime() - difference, mockSystemClockOffset)).toBe(true);
2525
});
2626
});
2727

28-
describe("returns false for time difference <300000", () => {
29-
it.each([299999, 100000, 0])("difference: %d", (difference) => {
28+
describe("returns false for time difference <240000", () => {
29+
it.each([239999, 100000, 0])("difference: %d", (difference) => {
3030
expect(isClockSkewed(mockSkewCorrectedDate.getTime() + difference, mockSystemClockOffset)).toBe(false);
3131
expect(isClockSkewed(mockSkewCorrectedDate.getTime() - difference, mockSystemClockOffset)).toBe(false);
3232
});

packages-internal/core/src/submodules/httpAuthSchemes/utils/isClockSkewed.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ import { getSkewCorrectedDate } from "./getSkewCorrectedDate";
99
* @param systemClockOffset - The offset of the system clock in milliseconds.
1010
*/
1111
export const isClockSkewed = (clockTime: number, systemClockOffset: number) =>
12-
Math.abs(getSkewCorrectedDate(systemClockOffset).getTime() - clockTime) >= 300000;
12+
Math.abs(getSkewCorrectedDate(systemClockOffset).getTime() - clockTime) >= 240000;

packages-internal/middleware-signing/src/utils/isClockSkewed.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,15 @@ describe(isClockSkewed.name, () => {
1818
vi.clearAllMocks();
1919
});
2020

21-
describe("returns true for time difference >=300000", () => {
22-
it.each([300000, 500000])("difference: %d", (difference) => {
21+
describe("returns true for time difference >=240000", () => {
22+
it.each([240000, 500000])("difference: %d", (difference) => {
2323
expect(isClockSkewed(mockSkewCorrectedDate.getTime() + difference, mockSystemClockOffset)).toBe(true);
2424
expect(isClockSkewed(mockSkewCorrectedDate.getTime() - difference, mockSystemClockOffset)).toBe(true);
2525
});
2626
});
2727

28-
describe("returns false for time difference <300000", () => {
29-
it.each([299999, 100000, 0])("difference: %d", (difference) => {
28+
describe("returns false for time difference <240000", () => {
29+
it.each([239999, 100000, 0])("difference: %d", (difference) => {
3030
expect(isClockSkewed(mockSkewCorrectedDate.getTime() + difference, mockSystemClockOffset)).toBe(false);
3131
expect(isClockSkewed(mockSkewCorrectedDate.getTime() - difference, mockSystemClockOffset)).toBe(false);
3232
});

packages-internal/middleware-signing/src/utils/isClockSkewed.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@ import { getSkewCorrectedDate } from "./getSkewCorrectedDate";
77
* @param systemClockOffset - The offset of the system clock in milliseconds.
88
*/
99
export const isClockSkewed = (clockTime: number, systemClockOffset: number) =>
10-
Math.abs(getSkewCorrectedDate(systemClockOffset).getTime() - clockTime) >= 300000;
10+
Math.abs(getSkewCorrectedDate(systemClockOffset).getTime() - clockTime) >= 240000;

0 commit comments

Comments
 (0)