AWS Smithy Client Middleware Issue

[samchungy]

Checkboxes for prior research

• I've gone through Developer Guide and API reference
• I've checked AWS Forums and StackOverflow.
• I've searched for previous similar issues and didn't find any solution.

Describe the bug

Since upgrading to 3.9.4 we've been running into

{"errorType":"Error","errorMessage":"serializerMiddleware is not found when adding endpointV2Middleware middleware before serializerMiddleware","stack":["Error: serializerMiddleware is not found when adding endpointV2Middleware middleware before serializerMiddleware","    at /var/runtime/node_modules/@aws-sdk/node_modules/@smithy/middleware-stack/dist-cjs/index.js:146:17","    at Array.forEach (<anonymous>)","    at getMiddlewareList (/var/runtime/node_modules/@aws-sdk/node_modules/@smithy/middleware-stack/dist-cjs/index.js:139:31)","    at Object.resolve (/var/runtime/node_modules/@aws-sdk/node_modules/@smithy/middleware-stack/dist-cjs/index.js:280:32)","    at GetSecretValueCommand.resolveMiddlewareWithContext (/var/task/node_modules/.pnpm/@smithy+smithy-client@4.9.8/node_modules/@smithy/smithy-client/dist-cjs/index.js:113:22)","    at GetSecretValueCommand.resolveMiddleware (/var/task/node_modules/.pnpm/@smithy+smithy-client@4.9.8/node_modules/@smithy/smithy-client/dist-cjs/index.js:193:29)","    at SecretsManagerClient.send (/var/runtime/node_modules/@aws-sdk/node_modules/@smithy/smithy-client/dist-cjs/index.js:81:25)","

Regression Issue

• Select this option if this issue appears to be a regression.

SDK version number

@aws-sdk/client-secrets-manager: 3.940.0

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

v22.20.0

Reproduction Steps

I can't seem to reproduce this locally but it happens within our Lambdas.

I believe it's due to our bundled aws-sdk version pulling in the Lambda runtime's @smithy/middleware-stack?

Observed Behavior

    const getSecretParams: GetSecretValueRequest = {
      SecretId: secretId,
    };
    const command = new GetSecretValueCommand(getSecretParams);

    const secretValue = await sm.send(command);

    return JSON.parse(
      secretValue.SecretString as string,
    ) as unknown as PrivateKey;

Expected Behavior

It should run without erroring

Possible Solution

No response

Additional Information/Context

No response

[kuhe]

Please check that your CDK deployment has not removed a subset of your application's node_module dependencies, so that all dependencies being executed in the Lambda are at the versions that you intend, rather than the versions that are bundled with the Lambda Node.js runtime.

Check the bundleAwsSDK setting described here:
https://github.com/aws/aws-cdk/blob/3d6b204797c8a004e3b6334fc4e447edcb710578/packages/aws-cdk-lib/aws-lambda-nodejs/README.md

To check what package versions are being executed within the Lambda fn, you can execute code such as:

import pkg from "@smithy/middleware-stack/package.json";
import clientPkg from "@aws-sdk/client-secrets-manager/package.json";

console.log({
  middleware: pkg.version,
  client: clientPkg.version,
});

As of v3.940.0 of secrets-manager, @smithy/middleware-stack at ^4.2.5 is required.

[samchungy]

Hmmm actually I suspect that this might be because we aren't hoisting the dependencies and Serverless isn't pulling in the deps properly.

[samchungy]

After I setup pnpm hoisting it seemed to resolve itself with Serverless. Thanks for your help @kuhe

[github-actions]

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.