Skip to content

Commit beeb445

Browse files
committed
minor doc update and CI fixes
1 parent 2d9dbac commit beeb445

File tree

4 files changed

+11
-14
lines changed

4 files changed

+11
-14
lines changed

CHANGELOG.rst

+3-2
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,12 @@ CHANGELOG
44

55
2.0.0
66
=====
7-
* **Breaking**: The default sampler now launches background tasks to poll sampling rules from X-Ray backend. See the new default sampling strategy in more details here:
7+
* **Breaking**: The default sampler now launches background tasks to poll sampling rules from X-Ray backend. See the new default sampling strategy in more details here: https://docs.aws.amazon.com/xray/latest/devguide/xray-sdk-python-configuration.html#xray-sdk-python-configuration-sampling.
88
* **Breaking**: The `should_trace` function in the sampler now takes a dictionary for sampling rule matching.
99
* **Breaking**: The original sampling modules for local defined rules are moved from `models.sampling` to `models.sampling.local`.
1010
* **Breaking**: The default behavior of `patch_all` changed to selectively patches libraries to avoid double patching. You can use `patch_all(double_patch=True)` to force it to patch ALL supported libraries. See more details on `ISSUE63 <https://github.com/aws/aws-xray-sdk-python/issues/63>`_
11-
* **Breaking** The latest `botocore` that has new X-Ray service API `GetSamplingRules` and `GetSamplingTargets` are required.
11+
* **Breaking**: The latest `botocore` that has new X-Ray service API `GetSamplingRules` and `GetSamplingTargets` are required.
12+
* **Breaking**: Version 2.x doesn't support pynamodb and aiobotocore as it requires botocore >= 1.11.3 which isn’t currently supported by the pynamodb and aiobotocore libraries. Please continue to use version 1.x if you’re using pynamodb or aiobotocore until those haven been updated to use botocore > = 1.11.3.
1213
* feature: Environment variable `AWS_XRAY_DAEMON_ADDRESS` now takes an additional notation in `tcp:127.0.0.1:2000 udp:127.0.0.2:2001` to set TCP and UDP destination separately. By default it assumes a X-Ray daemon listening to both UDP and TCP traffic on `127.0.0.1:2000`.
1314
* feature: Added MongoDB python client support. `PR65 <https://github.com/aws/aws-xray-sdk-python/pull/65>`_.
1415
* bugfix: Support binding connection in sqlalchemy as well as engine. `PR78 <https://github.com/aws/aws-xray-sdk-python/pull/78>`_.

aws_xray_sdk/core/patcher.py

+5-9
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,7 @@
44
log = logging.getLogger(__name__)
55

66
SUPPORTED_MODULES = (
7-
'aiobotocore',
87
'botocore',
9-
'pynamodb',
108
'requests',
119
'sqlite3',
1210
'mysql',
@@ -15,9 +13,7 @@
1513
)
1614

1715
NO_DOUBLE_PATCH = (
18-
'aiobotocore',
1916
'botocore',
20-
'pynamodb',
2117
'requests',
2218
'sqlite3',
2319
'mysql',
@@ -41,12 +37,12 @@ def patch(modules_to_patch, raise_errors=True):
4137
if module_to_patch == 'boto3':
4238
modules.add('botocore')
4339
# aioboto3 depends on aiobotocore and patching aiobotocore is sufficient
44-
elif module_to_patch == 'aioboto3':
45-
modules.add('aiobotocore')
40+
# elif module_to_patch == 'aioboto3':
41+
# modules.add('aiobotocore')
4642
# pynamodb requires botocore to be patched as well
47-
elif module_to_patch == 'pynamodb':
48-
modules.add('botocore')
49-
modules.add(module_to_patch)
43+
# elif module_to_patch == 'pynamodb':
44+
# modules.add('botocore')
45+
# modules.add(module_to_patch)
5046
else:
5147
modules.add(module_to_patch)
5248
unsupported_modules = modules - set(SUPPORTED_MODULES)

aws_xray_sdk/core/sampling/connector.py

+1
Original file line numberDiff line numberDiff line change
@@ -142,5 +142,6 @@ def _create_xray_client(self, ip='127.0.0.1', port='2000'):
142142
session = botocore.session.get_session()
143143
url = 'http://%s:%s' % (ip, port)
144144
return session.create_client('xray', endpoint_url=url,
145+
region_name='us-west-2',
145146
config=Config(signature_version=UNSIGNED)
146147
)

tox.ini

+2-3
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ skip_missing_interpreters = True
1111
deps =
1212
pytest > 3.0.0
1313
coverage
14-
botocore
1514
requests
1615
flask >= 0.10
1716
sqlalchemy
@@ -30,8 +29,8 @@ deps =
3029
py{35,36}: aiobotocore
3130

3231
commands =
33-
py{27,34}: coverage run --source aws_xray_sdk -m py.test tests --ignore tests/ext/aiohttp --ignore tests/ext/aiobotocore --ignore tests/test_async_local_storage.py --ignore tests/test_async_recorder.py
34-
py{35,36}: coverage run --source aws_xray_sdk -m py.test tests
32+
py{27,34}: coverage run --source aws_xray_sdk -m py.test tests --ignore tests/ext/aiohttp --ignore tests/ext/aiobotocore --ignore tests/test_async_local_storage.py --ignore tests/test_async_recorder.py --ignore tests/ext/pynamodb
33+
py{35,36}: coverage run --source aws_xray_sdk -m py.test tests --ignore tests/ext/aiobotocore --ignore tests/ext/pynamodb
3534

3635
setenv =
3736
DJANGO_SETTINGS_MODULE = tests.ext.django.app.settings

0 commit comments

Comments
 (0)