Skip to content

Commit 12c6c5d

Browse files
fix(release): forward container_type for base and ray releases
base and ray auto-releases fail at tag construction: ValueError("Tag template '{container_type}-{cuda_version}-{os_version}' requires variable 'container_type' but it was not provided") The deployed release logic derives base_dlc/ray release tags from a container_type template, but generate_release_spec.sh never forwarded that field and the base/ray configs never declared it. - generate_release_spec.sh: emit metadata.container_type into the release spec - base configs: add container_type (runtime / devel) - ray configs: add container_type (serve-ml; -sagemaker suffix comes from the existing platform field) Resulting tags are byte-identical to the prod_image values (runtime-cu130-amzn2023, devel-cu130-amzn2023, serve-ml-cuda, serve-ml-cpu, serve-ml-sagemaker-cuda, serve-ml-sagemaker-cpu), verified against the deployed release logic + construct_tags for all 8 base/ray configs.
1 parent 135141a commit 12c6c5d

9 files changed

Lines changed: 10 additions & 0 deletions

File tree

.github/actions/generate-release-spec/generate_release_spec.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ DEVICE_TYPE=$(yq '.metadata.device_type // ""' "$CONFIG_FILE")
3939
OS_VERSION=$(yq '.metadata.os_version // ""' "$CONFIG_FILE")
4040
CUSTOMER_TYPE=$(yq '.metadata.customer_type // ""' "$CONFIG_FILE")
4141
PLATFORM=$(yq '.metadata.platform // ""' "$CONFIG_FILE")
42+
CONTAINER_TYPE=$(yq '.metadata.container_type // ""' "$CONFIG_FILE")
4243

4344
# Derived fields
4445
PYTHON_RAW=$(yq '.build.python_version // ""' "$CONFIG_FILE")
@@ -84,6 +85,7 @@ SPEC+="version: \"${VERSION}\""$'\n'
8485
[[ -n "$CUDA_VERSION" ]] && SPEC+="cuda_version: \"${CUDA_VERSION}\""$'\n'
8586
[[ -n "$TRANSFORMERS_VERSION" ]] && SPEC+="transformers_version: \"${TRANSFORMERS_VERSION}\""$'\n'
8687
[[ -n "$PLATFORM" ]] && SPEC+="platform: \"${PLATFORM}\""$'\n'
88+
[[ -n "$CONTAINER_TYPE" ]] && SPEC+="container_type: \"${CONTAINER_TYPE}\""$'\n'
8789
[[ -n "$FORCE_RELEASE" ]] && SPEC+="force_release: ${FORCE_RELEASE}"$'\n'
8890
[[ -n "$PUBLIC_REGISTRY" ]] && SPEC+="public_registry: ${PUBLIC_REGISTRY}"$'\n'
8991
[[ -n "$PRIVATE_REGISTRY" ]] && SPEC+="private_registry: ${PRIVATE_REGISTRY}"$'\n'

.github/config/image/base/cu129-devel.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ metadata:
1010
arch_type: "x86"
1111
device_type: "gpu"
1212
job_type: "general"
13+
container_type: "devel"
1314
prod_image: "base:devel-cu129-amzn2023"
1415

1516
build:

.github/config/image/base/cu129-runtime.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ metadata:
1010
arch_type: "x86"
1111
device_type: "gpu"
1212
job_type: "general"
13+
container_type: "runtime"
1314
prod_image: "base:runtime-cu129-amzn2023"
1415

1516
build:

.github/config/image/base/cu130-devel.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ metadata:
1010
arch_type: "x86"
1111
device_type: "gpu"
1212
job_type: "general"
13+
container_type: "devel"
1314
prod_image: "base:devel-cu130-amzn2023"
1415

1516
build:

.github/config/image/base/cu130-runtime.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ metadata:
1010
arch_type: "x86"
1111
device_type: "gpu"
1212
job_type: "general"
13+
container_type: "runtime"
1314
prod_image: "base:runtime-cu130-amzn2023"
1415

1516
build:

.github/config/image/ray/ec2-cpu.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ metadata:
1010
arch_type: "x86"
1111
device_type: "cpu"
1212
job_type: "inference"
13+
container_type: "serve-ml"
1314
prod_image: "ray:serve-ml-cpu"
1415

1516
build:

.github/config/image/ray/ec2-gpu.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ metadata:
1010
arch_type: "x86"
1111
device_type: "gpu"
1212
job_type: "inference"
13+
container_type: "serve-ml"
1314
prod_image: "ray:serve-ml-cuda"
1415

1516
build:

.github/config/image/ray/sagemaker-cpu.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ metadata:
1111
arch_type: "x86"
1212
device_type: "cpu"
1313
job_type: "inference"
14+
container_type: "serve-ml"
1415
prod_image: "ray:serve-ml-sagemaker-cpu"
1516

1617
build:

.github/config/image/ray/sagemaker-gpu.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ metadata:
1111
arch_type: "x86"
1212
device_type: "gpu"
1313
job_type: "inference"
14+
container_type: "serve-ml"
1415
prod_image: "ray:serve-ml-sagemaker-cuda"
1516

1617
build:

0 commit comments

Comments
 (0)