Skip to content

Commit 164e128

Browse files
modify egress and ingress
1 parent 49ec039 commit 164e128

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

vllm/infra/ec2.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ def setup():
228228
# create fsx
229229
sg_fsx = fsx.create_security_group(vpc_id, "vllm-ec2-fsx-sg", "SG for Fsx Mounting")
230230
ingress_rules = [{"protocol": "tcp", "port": "988-1023"}]
231-
fsx.add_security_group_ingress_rules(sg_fsx, ingress_rules)
231+
fsx.add_security_group_ingress_and_egress_rules(sg_fsx, ingress_rules)
232232

233233
fsx_config = fsx.create_fsx_filesystem(
234234
subnet_ids[0], [sg_fsx], 1200, "SCRATCH_2", {"Name": "vllm-fsx-storage"}

vllm/infra/utils/fsx_utils.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ def delete_security_group(self, group_id: str):
151151
logger.error(f"Failed to create security group: {e}")
152152
raise
153153

154-
def add_security_group_ingress_rules(
154+
def add_security_group_ingress_and_egress_rules(
155155
self, security_group_id: str, ingress_rules: List[Dict[str, Any]]
156156
):
157157
"""
@@ -169,6 +169,12 @@ def add_security_group_ingress_rules(
169169
cmd += f" --{key} {value}"
170170
run(cmd)
171171

172+
for rule in ingress_rules:
173+
cmd = f"aws ec2 authorize-security-group-egress --group-id {security_group_id}"
174+
for key, value in rule.items():
175+
cmd += f" --{key} {value}"
176+
run(cmd)
177+
172178
logger.info(f"Added ingress rules to security group: {security_group_id}")
173179

174180
except Exception as e:

0 commit comments

Comments
 (0)