Skip to content

Commit 1ca3c3b

Browse files
committed
change conditions for vllm in MAINLINE to not skip eks and call test directly
1 parent c4fb3ec commit 1ca3c3b

File tree

1 file changed

+21
-12
lines changed

1 file changed

+21
-12
lines changed

test/testrunner.py

Lines changed: 21 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
)
3333
from test_utils import KEYS_TO_DESTROY_FILE
3434
from test_utils.pytest_cache import PytestCache
35-
from test.vllm.trigger_test import test_vllm_on_eks
35+
from test.vllm.trigger_test import test
3636

3737
from src.codebuild_environment import get_codebuild_project_name
3838

@@ -308,16 +308,25 @@ def main():
308308
)
309309
build_context = get_build_context()
310310

311-
# Skip non-sanity/security test suites for base or vllm images in MAINLINE context
312-
if (
313-
build_context == "MAINLINE"
314-
and all("base" in image_uri or "vllm" in image_uri for image_uri in all_image_list)
315-
and test_type not in {"functionality_sanity", "security_sanity"}
316-
):
317-
LOGGER.info(
318-
f"NOTE: {specific_test_type} tests not supported on base or vllm images. Skipping..."
319-
)
320-
return
311+
# Skip non-sanity/security test suites for base images in MAINLINE context
312+
# Skip non-sanity/security/eks test suites for vllm images in MAINLINE context
313+
if build_context == "MAINLINE":
314+
if (
315+
all("base" in image_uri for image_uri in all_image_list)
316+
and test_type not in {"functionality_sanity", "security_sanity"}
317+
):
318+
LOGGER.info(
319+
f"NOTE: {specific_test_type} tests not supported on base images. Skipping..."
320+
)
321+
return
322+
elif (
323+
all("vllm" in image_uri for image_uri in all_image_list)
324+
and test_type not in {"functionality_sanity", "security_sanity", "eks"}
325+
):
326+
LOGGER.info(
327+
f"NOTE: {specific_test_type} tests not supported on vllm images. Skipping..."
328+
)
329+
return
321330

322331
# quick_checks tests don't have images in it. Using a placeholder here for jobs like that
323332
try:
@@ -416,7 +425,7 @@ def main():
416425
if framework == "vllm":
417426
try:
418427
LOGGER.info(f"Running vLLM EKS tests with image: {all_image_list[0]}")
419-
test_vllm_on_eks(all_image_list[0])
428+
test()
420429
LOGGER.info("vLLM EKS tests completed successfully")
421430
# Exit function after vLLM tests
422431
return

0 commit comments

Comments
 (0)