Skip to content

Commit 1fc9eae

Browse files
committed
update ci-arch.md
Signed-off-by: sirutBuasai <sirutbuasai27@outlook.com>
1 parent cc42c80 commit 1fc9eae

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

.claude/rules/ci-architecture.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ paths:
3535
├── config/
3636
│ ├── image/ # Image configs (one file = one released image)
3737
│ │ ├── base/
38+
│ │ ├── huggingface-vllm/
3839
│ │ ├── pytorch/
3940
│ │ ├── sglang/
4041
│ │ ├── vllm/
@@ -45,7 +46,7 @@ paths:
4546
│ ├── sglang-model-tests.yml
4647
│ ├── vllm-model-tests.yml
4748
│ └── vllm-omni-model-tests.yml
48-
├── release_schedule.md # Autorelease cron schedule reference
49+
├── release-schedule.yml # Autorelease cron schedule (housekeeping, validated by prcheck)
4950
├── scripts/
5051
│ └── buildspec-cb-fleet.yml # CodeBuild fleet runner setup (installs uv, yq, jq)
5152
└── workflows/ # GitHub Actions workflows
@@ -87,6 +88,7 @@ scripts/
8788
└── docker/ # Docker build artifacts (COPY'd into images, run inside containers)
8889
├── common/ # Shared install scripts (EFA, OSS compliance, Python)
8990
├── telemetry/ # DLC telemetry (deep_learning_container.py, bash_telemetry template)
91+
├── huggingface/vllm/ # HF vLLM entrypoints, optimizations
9092
├── vllm/ # vLLM entrypoints, sagemaker_serve, patches
9193
├── sglang/ # SGLang entrypoints
9294
├── pytorch/ # PyTorch entrypoints, SSH config, NCCL
@@ -242,7 +244,7 @@ sglang.pr-amzn2023.yml (trigger + gatekeeper + check-changes + discover-configs)
242244
- **Callers use discover-configs matrix:** all PR and autorelease callers discover configs via glob pattern, then matrix-call the pipeline per config. This means adding a new image variant only requires adding a config file.
243245
- **Pipeline is per-framework:** one `sglang.pipeline.yml` handles all SGLang variants. A `ci-config` job parses the config to gate variant-specific tests (e.g., sagemaker test only runs for sagemaker configs, GPU tests only for GPU images).
244246
- **PR vs release:** identical pipeline call, different `release:` flag. Callers pass `release: false` (PR) or `release: true` (autorelease).
245-
- **Release gating:** pipelines use a `release-gate` job that checks `release.release` from config and generates the release spec. The actual release job calls `_reusable.release-image.yml`.
247+
- **Release gating:** pipelines use a `release-gate` job gated on three conditions: `github.ref == 'refs/heads/main'`, caller filename contains `.autorelease` or `.dispatch-release` (via `github.workflow_ref`), and `inputs.release == true`. This prevents accidental releases from PR workflows or non-main branches. The gate then checks `release.release` from config and generates the release spec. The actual release job calls `_reusable.release-image.yml`.
246248
- **Test-only runs:** when build is skipped (only test files changed), test jobs receive empty `image-uri` → `resolve-image-uri` action falls back to prod image from `metadata.prod_image`.
247249
- **Graceful skip:** `check-image-exists` action probes ECR; if image not found (first release scenario), tests skip cleanly.
248250
- **PR change detection:** `dorny/paths-filter` outputs per-test-suite flags. The pipeline receives `run-*-test` booleans. If `build-change` is true, all tests run.

0 commit comments

Comments
 (0)