Skip to content

Commit 1ff1164

Browse files
Add condition to check instance type for VLLM EC2 (#5191)
* Add condition to check instance type * Add condition to check instance type * revert toml * revert toml
1 parent 605ee93 commit 1ff1164

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

test/testrunner.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,6 @@ def main():
428428
try:
429429
LOGGER.info(f"Running vLLM EKS EC2 tests with image: {all_image_list[0]}")
430430
test_vllm()
431-
LOGGER.info("vLLM EKS EC2 tests completed successfully")
432431
# Exit function after vLLM tests
433432
return
434433
except Exception as e:

test/vllm/trigger_test.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import logging
33
from typing import List
44

5-
from test.test_utils import get_dlc_images
5+
from test.test_utils import get_dlc_images, is_pr_context
66
from test.vllm.eks.eks_test import test_vllm_on_eks
77
from test.vllm.ec2.infra.setup_ec2 import setup
88
from test.vllm.ec2.test_artifacts.test_ec2 import test_vllm_on_ec2
@@ -12,11 +12,16 @@
1212
LOGGER.addHandler(logging.StreamHandler(sys.stdout))
1313

1414

15-
def run_platform_tests(platform: str, images: List[str], commit_id: str, ipv6_enabled: bool):
15+
def run_platform_tests(platform: str, images: List[str]):
1616
"""
1717
Run tests for a specific platform
1818
"""
19-
LOGGER.info(f"Running {platform} tests")
19+
instance_type = os.getenv("EC2_GPU_INSTANCE_TYPE")
20+
21+
if instance_type == "p4d.24xlarge":
22+
LOGGER.info(f"Skipping tests on {instance_type} instance type")
23+
return
24+
2025
if platform == "ec2":
2126
try:
2227
ec2_resources = setup()
@@ -60,8 +65,6 @@ def test():
6065
run_platform_tests(
6166
platform=test_type,
6267
images=standard_images_list,
63-
commit_id=commit_id,
64-
ipv6_enabled=ipv6_enabled,
6568
)
6669

6770

0 commit comments

Comments
 (0)