Skip to content

Commit 221a10c

Browse files
ray-train: make all Dockerfile ARGs config-driven
Every Dockerfile ARG must come from the config; the Dockerfile default is only a fallback for bare 'docker build'. Add the missing ones to both configs: - builder_base_image, base_image (were relying on Dockerfile defaults) - python_short_version (venv site-packages path; was Dockerfile-only) Drop redundant build.framework_version — the build-image action already injects FRAMEWORK_VERSION from metadata.framework_version (kept in metadata as required).
1 parent 4645d33 commit 221a10c

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

.github/config/image/ray-train/ec2-gpu.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,11 @@ metadata:
1616
build:
1717
dockerfile: "docker/ray-train/Dockerfile.cuda"
1818
target: "ec2"
19+
builder_base_image: "public.ecr.aws/deep-learning-containers/base:devel-cu130-amzn2023"
20+
base_image: "public.ecr.aws/deep-learning-containers/base:runtime-cu130-amzn2023"
1921
python_version: "3.13.12"
22+
python_short_version: "3.13"
2023
cuda_version: "13.0.2"
21-
framework_version: "2.56.0"
2224
torch_version: "2.13.0"
2325
efa_version: "1.47.0"
2426
gdrcopy_version: "2.4.4"

.github/config/image/ray-train/eks-gpu.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,11 @@ metadata:
1717
build:
1818
dockerfile: "docker/ray-train/Dockerfile.cuda"
1919
target: "eks"
20+
builder_base_image: "public.ecr.aws/deep-learning-containers/base:devel-cu130-amzn2023"
21+
base_image: "public.ecr.aws/deep-learning-containers/base:runtime-cu130-amzn2023"
2022
python_version: "3.13.12"
23+
python_short_version: "3.13"
2124
cuda_version: "13.0.2"
22-
framework_version: "2.56.0"
2325
torch_version: "2.13.0"
2426
efa_version: "1.47.0"
2527
gdrcopy_version: "2.4.4"

0 commit comments

Comments
 (0)