Skip to content

Commit 2f3e79d

Browse files
author
Yadan Wei
committed
fix test setup
Signed-off-by: Yadan Wei <yadanwei@amazon.com>
1 parent 14c44da commit 2f3e79d

File tree

1 file changed

+22
-11
lines changed

1 file changed

+22
-11
lines changed

.github/workflows/pr-vllm.yml

Lines changed: 22 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,7 @@ jobs:
160160
outputs:
161161
aws-account-id: ${{ steps.set-env.outputs.AWS_ACCOUNT_ID }}
162162
image-uri: ${{ steps.set-env.outputs.IMAGE_URI }}
163+
framework-version: ${{ steps.config.outputs.framework-version }}
163164
steps:
164165
- name: Checkout code
165166
uses: actions/checkout@v4
@@ -211,7 +212,7 @@ jobs:
211212
uses: actions/checkout@v5
212213
with:
213214
repository: vllm-project/vllm
214-
ref: v${{ env.VLLM_VERSION }}
215+
ref: v${{ needs.set-ec2-test-environment.outputs.framework-version }}
215216
path: vllm_source
216217

217218
- name: Start container
@@ -257,7 +258,7 @@ jobs:
257258
uses: actions/checkout@v5
258259
with:
259260
repository: vllm-project/vllm
260-
ref: v${{ env.VLLM_VERSION }}
261+
ref: v${{ needs.set-ec2-test-environment.outputs.framework-version }}
261262
path: vllm_source
262263

263264
- name: Start container
@@ -303,7 +304,7 @@ jobs:
303304
uses: actions/checkout@v5
304305
with:
305306
repository: vllm-project/vllm
306-
ref: v${{ env.VLLM_VERSION }}
307+
ref: v${{ needs.set-ec2-test-environment.outputs.framework-version }}
307308
path: vllm_source
308309

309310
- name: Start container
@@ -391,6 +392,7 @@ jobs:
391392
outputs:
392393
aws-account-id: ${{ steps.set-env.outputs.AWS_ACCOUNT_ID }}
393394
image-uri: ${{ steps.set-env.outputs.IMAGE_URI }}
395+
framework-version: ${{ steps.config.outputs.framework-version }}
394396
steps:
395397
- name: Checkout code
396398
uses: actions/checkout@v4
@@ -399,6 +401,7 @@ jobs:
399401
id: config
400402
run: |
401403
echo '${{ needs.load-config.outputs.rayserve-config }}' > config.json
404+
echo "framework-version=$(jq -r '.common.framework_version' config.json)" >> $GITHUB_OUTPUT
402405
echo "prod-image=$(jq -r '.common.prod_image' config.json)" >> $GITHUB_OUTPUT
403406
404407
- name: Set test environment
@@ -441,7 +444,7 @@ jobs:
441444
uses: actions/checkout@v5
442445
with:
443446
repository: vllm-project/vllm
444-
ref: v${{ env.VLLM_RAYSERVE_VERSION }}
447+
ref: v${{ needs.set-rayserve-test-environment.outputs.framework-version }}
445448
path: vllm_source
446449

447450
- name: Start container
@@ -487,7 +490,7 @@ jobs:
487490
uses: actions/checkout@v5
488491
with:
489492
repository: vllm-project/vllm
490-
ref: v${{ env.VLLM_RAYSERVE_VERSION }}
493+
ref: v${{ needs.set-rayserve-test-environment.outputs.framework-version }}
491494
path: vllm_source
492495

493496
- name: Start container
@@ -533,7 +536,7 @@ jobs:
533536
uses: actions/checkout@v5
534537
with:
535538
repository: vllm-project/vllm
536-
ref: v${{ env.VLLM_RAYSERVE_VERSION }}
539+
ref: v${{ needs.set-rayserve-test-environment.outputs.framework-version }}
537540
path: vllm_source
538541

539542
- name: Start container
@@ -609,7 +612,7 @@ jobs:
609612
customer-type: ${{ steps.config.outputs.customer-type }}
610613

611614
set-sagemaker-test-environment:
612-
needs: [check-changes, build-vllm-sagemaker-image]
615+
needs: [check-changes, build-vllm-sagemaker-image, load-config]
613616
if: |
614617
always() && !failure() && !cancelled() &&
615618
(needs.check-changes.outputs.build-change == 'true' || needs.check-changes.outputs.test-change == 'true')
@@ -620,10 +623,18 @@ jobs:
620623
outputs:
621624
aws-account-id: ${{ steps.set-env.outputs.AWS_ACCOUNT_ID }}
622625
image-uri: ${{ steps.set-env.outputs.IMAGE_URI }}
626+
framework-version: ${{ steps.config.outputs.framework-version }}
623627
steps:
624628
- name: Checkout code
625629
uses: actions/checkout@v4
626630

631+
- name: Parse SageMaker config
632+
id: config
633+
run: |
634+
echo '${{ needs.load-config.outputs.sagemaker-config }}' > config.json
635+
echo "framework-version=$(jq -r '.common.framework_version' config.json)" >> $GITHUB_OUTPUT
636+
echo "prod-image=$(jq -r '.common.prod_image' config.json)" >> $GITHUB_OUTPUT
637+
627638
- name: Set test environment
628639
id: set-env
629640
run: |
@@ -632,7 +643,7 @@ jobs:
632643
IMAGE_URI=${{ needs.build-vllm-sagemaker-image.outputs.ci-image }}
633644
else
634645
AWS_ACCOUNT_ID=${{ vars.PROD_AWS_ACCOUNT_ID }}
635-
IMAGE_URI=${{ vars.PROD_AWS_ACCOUNT_ID }}.dkr.ecr.${{ vars.AWS_REGION }}.amazonaws.com/${{ env.PROD_SAGEMAKER_IMAGE }}
646+
IMAGE_URI=${{ vars.PROD_AWS_ACCOUNT_ID }}.dkr.ecr.${{ vars.AWS_REGION }}.amazonaws.com/${{ steps.config.outputs.prod-image }}
636647
fi
637648
638649
echo "Image URI to test: ${IMAGE_URI}"
@@ -664,7 +675,7 @@ jobs:
664675
uses: actions/checkout@v5
665676
with:
666677
repository: vllm-project/vllm
667-
ref: v${{ env.VLLM_VERSION }}
678+
ref: v${{ needs.set-sagemaker-test-environment.outputs.framework-version }}
668679
path: vllm_source
669680

670681
- name: Start container
@@ -710,7 +721,7 @@ jobs:
710721
uses: actions/checkout@v5
711722
with:
712723
repository: vllm-project/vllm
713-
ref: v${{ env.VLLM_VERSION }}
724+
ref: v${{ needs.set-sagemaker-test-environment.outputs.framework-version }}
714725
path: vllm_source
715726

716727
- name: Start container
@@ -756,7 +767,7 @@ jobs:
756767
uses: actions/checkout@v5
757768
with:
758769
repository: vllm-project/vllm
759-
ref: v${{ env.VLLM_VERSION }}
770+
ref: v${{ needs.set-sagemaker-test-environment.outputs.framework-version }}
760771
path: vllm_source
761772

762773
- name: Start container

0 commit comments

Comments
 (0)