Skip to content

Commit 49c31fa

Browse files
committed
2 parents 2ed025f + 7309d67 commit 49c31fa

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

src/constants.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@
2525
"autogluon",
2626
"stabilityai_pytorch",
2727
"base",
28+
"vllm",
29+
"sglang",
2830
}
2931
DEVICE_TYPES = {"cpu", "gpu", "hpu", "eia", "inf", "neuron", "neuronx"}
3032
IMAGE_TYPES = {"training", "inference"}

test/dlc_tests/sanity/test_pre_release.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -875,9 +875,10 @@ def _test_framework_and_cuda_version(gpu, ec2_connection):
875875
:param ec2_connection: fixture to establish connection with an ec2 instance
876876
"""
877877
image = gpu
878-
if "base" in image or "vllm" in image:
878+
general_types = ["base", "vllm", "sglang"]
879+
if any(t in image for t in general_types):
879880
pytest.skip(
880-
"Base/vLLM DLC has doesn't follow the assumptions made by inference/training. Skipping test."
881+
f"{', '.join(upstream_t_typesypes)} images do not follow the assumptions made by inference/training. Skipping test."
881882
)
882883
tested_framework, tag_framework_version = get_framework_and_version_from_tag(image)
883884

@@ -1247,10 +1248,10 @@ def test_package_version_regression_in_image(image):
12471248
keys in the buildspec - as these keys are used to extract the released image uri. Additionally, if the image is not already
12481249
released, this test would be skipped.
12491250
"""
1250-
if "base" in image or "vllm" in image:
1251-
pytest.skip(
1252-
"Base/vLLM images don't have python packages that needs to be checked. Skipping test."
1253-
)
1251+
general_types = ["base", "vllm", "sglang"]
1252+
if any(t in image for t in general_types):
1253+
pytest.skip(f"{', '.join(general_types)} images don't have python packages that needs to be checked. Skipping test.")
1254+
12541255
dlc_path = os.getcwd().split("/test/")[0]
12551256
corresponding_image_spec = get_image_spec_from_buildspec(
12561257
image_uri=image, dlc_folder_path=dlc_path

0 commit comments

Comments
 (0)