Change default region for uris (#5616)

sirutBuasai · web-flow · commit 507ddf2455f3 · 2026-01-29T19:33:13.000Z
* rename accouncements

Signed-off-by: sirutBuasai &lt;sirutbuasai27@outlook.com&gt;

* change default region to us-west-2

Signed-off-by: sirutBuasai &lt;sirutbuasai27@outlook.com&gt;

* readd current releasenotes

Signed-off-by: sirutBuasai &lt;sirutbuasai27@outlook.com&gt;

* readd current releasenotes

Signed-off-by: sirutBuasai &lt;sirutbuasai27@outlook.com&gt;

---------

Signed-off-by: sirutBuasai &lt;sirutbuasai27@outlook.com&gt;
diff --git a/docs/DEVELOPMENT.md b/docs/DEVELOPMENT.md
@@ -94,7 +94,7 @@ ______________________________________________________________________
 Add these fields to an image config:
 
 ```yaml
-announcement:
+announcements:
   - "Introduced containers for PyTorch 2.9"
   - "Added Python 3.12 support"
 
@@ -109,7 +109,7 @@ optional:
     - "Description of known issue"
 ```
 
-Release notes are generated automatically for images with `announcement` and `packages` fields.
+Release notes are generated automatically for images with `announcements` and `packages` fields.
 
 ### Adding New Optional Sections
 
@@ -228,4 +228,4 @@ ______________________________________________________________________
 | "Display name not found" | Add repository to `display_names` in `global.yml` |
 | "Inconsistent dates" | Ensure all images in same framework group/version have identical GA/EOP |
 | Images not appearing | Check repository is in `table_order` |
-| Release notes not generating | Ensure `announcement` and `packages` fields are present |
+| Release notes not generating | Ensure `announcements` and `packages` fields are present |
diff --git a/docs/src/constants.py b/docs/src/constants.py
@@ -28,7 +28,7 @@
 TUTORIALS_DIR = DOCS_DIR / "tutorials"
 
 # Release notes configuration
-RELEASE_NOTES_REQUIRED_FIELDS = ["announcement", "packages"]
+RELEASE_NOTES_REQUIRED_FIELDS = ["announcements", "packages"]
 GLOBAL_CONFIG_PATH = SRC_DIR / "global.yml"
 
 AVAILABLE_IMAGES_TABLE_HEADER = "##"
diff --git a/docs/src/data/template/image-template.yml b/docs/src/data/template/image-template.yml
@@ -67,10 +67,10 @@ eop: "2026-10-15"
 # -----------------------------------------------------------------------------
 # Release Notes Fields
 # -----------------------------------------------------------------------------
-# Required for release notes generation: announcement and packages
+# Required for release notes generation: announcements and packages
 
-# Announcement bullet points for the release note
-announcement:
+# Announcements bullet points for the release note
+announcements:
   - "Introduced containers for PyTorch 2.9 for Training"
   - "Added Python 3.12 support"
 
diff --git a/docs/src/generate.py b/docs/src/generate.py
@@ -56,7 +56,7 @@ def _generate_individual_release_note(
         framework=img.get("framework"),
         version=img.get("version"),
         platform_display=img.display_platform,
-        announcement=img.get("announcement", []),
+        announcements=img.get("announcements", []),
         packages=img.get("packages", {}),
         image_uris=img.get_image_uris(),
         optional=img.get("optional", {}),
diff --git a/docs/src/global.yml b/docs/src/global.yml
@@ -38,6 +38,7 @@ accelerators:
 
 # ECR configuration
 example_ecr_account: "763104351884"
+example_region: "us-west-2"
 
 # =============================================================================
 # Display Names
diff --git a/docs/src/image_config.py b/docs/src/image_config.py
@@ -96,13 +96,14 @@ def display_release_note_link(self) -> str:
     def get_image_uris(self) -> list[str]:
         """Get list of image URIs (private ECR + public ECR if available)."""
         account = self.get("example_ecr_account", GLOBAL_CONFIG["example_ecr_account"])
+        region = self.get("example_region", GLOBAL_CONFIG["example_region"])
         tags = self.get("tags", [])
         if not isinstance(tags, list):
             raise ValueError(f"'tags' field must be a list in {self._repository}")
 
         uris = []
         for tag in tags:
-            uris.append(build_ecr_uri(account, self._repository, tag))
+            uris.append(build_ecr_uri(account, self._repository, tag, region))
 
         if self.get("public_registry"):
             for tag in tags:
diff --git a/docs/src/templates/releasenotes/release_note.template.md b/docs/src/templates/releasenotes/release_note.template.md
@@ -2,8 +2,8 @@
 
 {{ dlc_long }} for {{ platform_display }} are now available with {{ framework }} {{ version }}.
 
-## Announcement
-{% for item in announcement %}
+## Announcements
+{% for item in announcements %}
 - {{ item }}
 {% endfor %}
 
diff --git a/test/docs/mock_data/data/mock-repo/0.5-cpu-ec2.yml b/test/docs/mock_data/data/mock-repo/0.5-cpu-ec2.yml
@@ -11,7 +11,7 @@ public_registry: false
 tags:
   - "0.5.0-cpu-py39-ubuntu20.04-ec2"
 
-announcement:
+announcements:
   - "Initial MockFramework 0.5 release"
 
 packages:
diff --git a/test/docs/mock_data/data/mock-repo/3.0-gpu-ec2.yml b/test/docs/mock_data/data/mock-repo/3.0-gpu-ec2.yml
@@ -12,7 +12,7 @@ public_registry: true
 tags:
   - "3.0.0-gpu-py312-cu130-ubuntu22.04-ec2"
 
-announcement:
+announcements:
   - "Introduced MockFramework 3.0 containers"
   - "Added CUDA 13.0 support"
 
diff --git a/test/docs/test_generate_release_notes.py b/test/docs/test_generate_release_notes.py
@@ -60,7 +60,7 @@ def supported_image():
         python="py312",
         eop="2500-01-01",
         tags=["3.0.0-gpu-py312-ec2"],
-        announcement=["Introduced MockFramework 3.0", "Added GPU support"],
+        announcements=["Introduced MockFramework 3.0", "Added GPU support"],
         packages={"python": "3.12", "mockframework": "3.0.0"},
     )
 
@@ -77,7 +77,7 @@ def deprecated_image():
         python="py39",
         eop="2025-01-01",
         tags=["0.5.0-cpu-py39-ec2"],
-        announcement=["Initial release"],
+        announcements=["Initial release"],
         packages={"python": "3.9", "mockframework": "0.5.0"},
     )
 
@@ -95,7 +95,7 @@ def test_individual_release_note_content(
     assert "3.0" in content
     assert "EC2" in content
 
-    # Announcement section
+    # Announcements section
     assert "Introduced MockFramework 3.0" in content
     assert "Added GPU support" in content
 
