Skip to content

Commit 5c3b37e

Browse files
committed
skip smddp and smppy tests, allowlist protobuf CVE 77740 - blocked by sm pytorch training dep
1 parent 0490e9d commit 5c3b37e

File tree

3 files changed

+13
-2
lines changed

3 files changed

+13
-2
lines changed
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"77740": "Affected versions of this package are vulnerable to a potential Denial of Service (DoS) attack due to unbounded recursion when parsing untrusted Protocol Buffers data. The pure-Python implementation fails to enforce recursion depth limits when processing recursive groups, recursive messages, or a series of SGROUP tags, leading to stack overflow conditions that can crash the application by exceeding Python's recursion limit."
3+
}
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"77740": "Affected versions of this package are vulnerable to a potential Denial of Service (DoS) attack due to unbounded recursion when parsing untrusted Protocol Buffers data. The pure-Python implementation fails to enforce recursion depth limits when processing recursive groups, recursive messages, or a series of SGROUP tags, leading to stack overflow conditions that can crash the application by exceeding Python's recursion limit."
3+
}

test/sagemaker_tests/pytorch/training/conftest.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -500,7 +500,12 @@ def skip_smddataparallel_test(
500500
For each currency release, we can skip SMDDP tests if the binary does not exist.
501501
However, when the SMDDP binaries are added, be sure to fix the test logic such that the tests are not skipped.
502502
"""
503-
skip_dict = {"==2.0.*": ["cu121"], ">=2.6,<2.7.1": ["cu126"], ">=2.7.1,<2.8": ["cu128"]}
503+
skip_dict = {
504+
"==2.0.*": ["cu121"],
505+
">=2.6,<2.7.1": ["cu126"],
506+
">=2.7.1,<2.8": ["cu128"],
507+
">=2.8,<2.9": ["cu129"],
508+
}
504509
if _validate_pytorch_framework_version(
505510
request, processor, ecr_image, "skip_smddataparallel_test", skip_dict
506511
):
@@ -516,7 +521,7 @@ def skip_smppy_test(
516521
"""For each currency release, we can skip smppy tests if the Profiler binary does not exist.
517522
However, when the Profiler binaries are added, be sure to fix the test logic such that the tests are not skipped.
518523
"""
519-
skip_dict = {">=2.7.1,<2.8": ["cpu", "cu128"]}
524+
skip_dict = {">=2.7.1,<2.8": ["cpu", "cu128"], ">=2.8,<2.9": ["cpu", "cu129"]}
520525
if _validate_pytorch_framework_version(
521526
request, processor, ecr_image, "skip_smppy_test", skip_dict
522527
):

0 commit comments

Comments
 (0)