fix(ci): prevent release job from inheriting upstream skip (#6307)

The release job used a bare conditional (needs.release-gate.outputs.should-release == 'true')
with no status check function. When upstream test jobs (security/sagemaker/efa) were
skipped, GitHub Actions propagated that skip to release, so it never ran even when
release-gate succeeded and set should-release=true.

Add !failure() && !cancelled() to break the propagated skip, matching the pattern
already used by release-gate and the test jobs.

Signed-off-by: Sally Seok <sallyseo@amazon.com>

Author: sallyseok

.github/workflows/base.pipeline.yml

@@ -110,7 +110,7 @@ jobs:
           config-file: ${{ inputs.config-file }}
 
   release:
-    if: ${{ needs.release-gate.outputs.should-release == 'true' }}
+    if: ${{ !failure() && !cancelled() && needs.release-gate.outputs.should-release == 'true' }}
     needs: [build, release-gate]
     uses: ./.github/workflows/_reusable.release-image.yml
     with:

.github/workflows/huggingface-vllm.pipeline.yml

@@ -142,7 +142,7 @@ jobs:
           config-file: ${{ inputs.config-file }}
 
   release:
-    if: ${{ needs.release-gate.outputs.should-release == 'true' }}
+    if: ${{ !failure() && !cancelled() && needs.release-gate.outputs.should-release == 'true' }}
     needs: [build, release-gate]
     uses: ./.github/workflows/_reusable.release-image.yml
     with:

.github/workflows/lambda.pipeline.yml

@@ -193,7 +193,7 @@ jobs:
           config-file: ${{ inputs.config-file }}
 
   release:
-    if: ${{ needs.release-gate.outputs.should-release == 'true' }}
+    if: ${{ !failure() && !cancelled() && needs.release-gate.outputs.should-release == 'true' }}
     needs: [build, release-gate]
     uses: ./.github/workflows/_reusable.release-image.yml
     with:

.github/workflows/pytorch.pipeline.yml

@@ -242,7 +242,7 @@ jobs:
           config-file: ${{ inputs.config-file }}
 
   release:
-    if: ${{ needs.release-gate.outputs.should-release == 'true' }}
+    if: ${{ !failure() && !cancelled() && needs.release-gate.outputs.should-release == 'true' }}
     needs: [build, release-gate]
     uses: ./.github/workflows/_reusable.release-image.yml
     with:

.github/workflows/ray.pipeline.yml

@@ -186,7 +186,7 @@ jobs:
           config-file: ${{ inputs.config-file }}
 
   release:
-    if: ${{ needs.release-gate.outputs.should-release == 'true' }}
+    if: ${{ !failure() && !cancelled() && needs.release-gate.outputs.should-release == 'true' }}
     needs: [build, release-gate]
     uses: ./.github/workflows/_reusable.release-image.yml
     with:

.github/workflows/sglang.pipeline.yml

@@ -208,7 +208,7 @@ jobs:
           config-file: ${{ inputs.config-file }}
 
   release:
-    if: ${{ needs.release-gate.outputs.should-release == 'true' }}
+    if: ${{ !failure() && !cancelled() && needs.release-gate.outputs.should-release == 'true' }}
     needs: [build, release-gate]
     uses: ./.github/workflows/_reusable.release-image.yml
     with:

.github/workflows/vllm-omni.pipeline.yml

@@ -171,7 +171,7 @@ jobs:
           config-file: ${{ inputs.config-file }}
 
   release:
-    if: ${{ needs.release-gate.outputs.should-release == 'true' }}
+    if: ${{ !failure() && !cancelled() && needs.release-gate.outputs.should-release == 'true' }}
     needs: [build, release-gate]
     uses: ./.github/workflows/_reusable.release-image.yml
     with:

.github/workflows/vllm.pipeline.yml

@@ -207,7 +207,7 @@ jobs:
           config-file: ${{ inputs.config-file }}
 
   release:
-    if: ${{ needs.release-gate.outputs.should-release == 'true' }}
+    if: ${{ !failure() && !cancelled() && needs.release-gate.outputs.should-release == 'true' }}
     needs: [build, release-gate]
     uses: ./.github/workflows/_reusable.release-image.yml
     with:

.github/workflows/xgboost.pipeline.yml

@@ -173,7 +173,7 @@ jobs:
           config-file: ${{ inputs.config-file }}
 
   release:
-    if: ${{ needs.release-gate.outputs.should-release == 'true' }}
+    if: ${{ !failure() && !cancelled() && needs.release-gate.outputs.should-release == 'true' }}
     needs: [build, release-gate]
     uses: ./.github/workflows/_reusable.release-image.yml
     with: