Skip to content

Commit 75a8f1a

Browse files
committed
try artifact
Signed-off-by: Junpu Fan <junpu@amazon.com>
1 parent 2d59406 commit 75a8f1a

File tree

1 file changed

+24
-53
lines changed

1 file changed

+24
-53
lines changed

.github/workflows/pr-example.yml

Lines changed: 24 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,6 @@ jobs:
3939
runs-on:
4040
- codebuild-runner-${{ github.run_id }}-${{ github.run_attempt }}
4141
fleet:x86-build-runner
42-
outputs:
43-
image_uri: ${{ steps.export.outputs.image_uri }}
4442
steps:
4543
- uses: actions/checkout@v5
4644
- run: .github/scripts/runner_setup.sh
@@ -60,60 +58,33 @@ jobs:
6058
-f docker/vllm/Dockerfile.rayserve .
6159
docker push "$IMAGE_TAG"
6260
docker rmi "$IMAGE_TAG"
63-
echo "IMAGE_TAG=$IMAGE_TAG" >> $GITHUB_ENV
64-
- name: Export output
65-
id: export
66-
run: echo "image_uri=$IMAGE_TAG" >> $GITHUB_OUTPUT
67-
- name: Debug local
68-
run: |
69-
echo "Local GITHUB_OUTPUT contents:"
70-
cat $GITHUB_OUTPUT || echo "No output file found"
71-
echo "Local step output: ${{ steps.export.outputs.image_uri }}"
72-
73-
test-job1:
74-
needs: [build-vllm-rayserve-ec2-image]
75-
runs-on:
76-
- codebuild-runner-${{ github.run_id }}-${{ github.run_attempt }}
77-
fleet:x86-build-runner
78-
if: always()
79-
steps:
80-
- name: Check received output
81-
run: |
82-
echo "Received job output: ${{ needs.build-vllm-rayserve-ec2-image.outputs.image_uri }}"
83-
if [ -z "${{ needs.build-vllm-rayserve-ec2-image.outputs.image_uri }}" ]; then
84-
echo "❌ Output is missing!"
85-
else
86-
echo "✅ Output received successfully."
87-
fi
61+
echo "$IMAGE_TAG" > image_uri.txt
62+
- name: Upload image URI
63+
uses: actions/upload-artifact@v4
64+
with:
65+
name: vllm-rayserve-ec2-image-uri
66+
path: image_uri.txt
8867

89-
test-job2:
68+
test-vllm-rayserve-ec2-image:
9069
needs: [build-vllm-rayserve-ec2-image]
91-
runs-on:
70+
if: needs.build-vllm-rayserve-ec2-image.result == 'success'
71+
runs-on:
9272
- codebuild-runner-${{ github.run_id }}-${{ github.run_attempt }}
9373
fleet:x86-g6xl-runner
94-
if: always()
9574
steps:
96-
- name: Check received output
75+
- uses: actions/checkout@v5
76+
- name: Download image URI
77+
uses: actions/download-artifact@v4
78+
with:
79+
name: vllm-rayserve-ec2-image-uri
80+
- name: Read image URI
81+
id: read
9782
run: |
98-
echo "Received job output: ${{ needs.build-vllm-rayserve-ec2-image.outputs.image_uri }}"
99-
if [ -z "${{ needs.build-vllm-rayserve-ec2-image.outputs.image_uri }}" ]; then
100-
echo "❌ Output is missing!"
101-
else
102-
echo "✅ Output received successfully."
103-
fi
104-
105-
# test-vllm-rayserve-ec2-image:
106-
# needs: [build-vllm-rayserve-ec2-image]
107-
# if: needs.build-vllm-rayserve-ec2-image.result == 'success'
108-
# runs-on:
109-
# - codebuild-runner-${{ github.run_id }}-${{ github.run_attempt }}
110-
# fleet:x86-g6xl-runner
111-
# steps:
112-
# - uses: actions/checkout@v5
113-
# - name: Use built image
114-
# run: |
115-
# IMAGE_URI=${{ needs.build-vllm-rayserve-ec2-image.outputs.image_uri }}
116-
# echo "Testing image: $IMAGE_URI"
117-
# aws ecr get-login-password --region ${{ secrets.AWS_REGION }} | docker login --username AWS --password-stdin ${{ secrets.AWS_ACCOUNT_ID }}.dkr.ecr.${{ secrets.AWS_REGION }}.amazonaws.com
118-
# docker pull "$IMAGE_URI"
119-
# docker run --rm "$IMAGE_URI" python -c "import torch; import ray; import vllm; print('Test OK')"
83+
IMAGE_URI=$(cat image_uri.txt)
84+
echo "IMAGE_URI=$IMAGE_URI" >> $GITHUB_ENV
85+
echo "Resolved image URI: $IMAGE_URI"
86+
- name: Test image
87+
run: |
88+
aws ecr get-login-password --region ${{ secrets.AWS_REGION }} | docker login --username AWS --password-stdin ${{ secrets.AWS_ACCOUNT_ID }}.dkr.ecr.${{ secrets.AWS_REGION }}.amazonaws.com
89+
docker pull "$IMAGE_URI"
90+
docker run --rm "$IMAGE_URI" python -c "import torch; import ray; import vllm; print('Test OK')"

0 commit comments

Comments
 (0)