Skip to content

Commit aa121a0

Browse files
author
Bhanu Teja Goshikonda
committed
fix(pytorch): pass --disable-ngc to EFA installer for 1.48+
Starting with EFA 1.48, the installer auto-detects NGC containers via /opt/nvidia/nvidia_entrypoint.sh (present in nvidia/cuda:*-amzn2023 base images) and skips installing the AL2023 libnccl-ofi RPM. This left the pytorch runtime image without libnccl-net.so, breaking every unit / sanity / single-gpu / efa test that asserts the OFI plugin is present. The sibling scripts/docker/common/install_efa_amzn2023.sh already has this fix (lines 37-48); mirror the version-gated --disable-ngc flag here so aws-ofi-nccl installs regardless of the base-image NGC detection. Only affects pytorch - sglang, vllm, and vllm-omni use the common installer via their own paths.
1 parent 66b9fe3 commit aa121a0

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

scripts/docker/pytorch/install_efa.sh

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,13 @@ mkdir -p /tmp/efa && cd /tmp/efa
1010
curl -O "https://s3-us-west-2.amazonaws.com/aws-efa-installer/aws-efa-installer-${EFA_VERSION}.tar.gz"
1111
tar -xf "aws-efa-installer-${EFA_VERSION}.tar.gz"
1212
cd aws-efa-installer
13-
./efa_installer.sh -y --skip-kmod --skip-limit-conf --no-verify
13+
# EFA 1.48+ auto-detects NGC containers (via /opt/nvidia/nvidia_entrypoint.sh
14+
# in nvidia/cuda:*-amzn2023 bases) and skips the AL2023 libnccl-ofi RPM.
15+
# Force the standard install with --disable-ngc so aws-ofi-nccl gets installed.
16+
ver_ge() { [ "$1" = "$2" ] || [ "$2" = "$(printf '%s\n' "$1" "$2" | sort -V | head -n1)" ]; }
17+
EFA_EXTRA_ARGS=""
18+
ver_ge "$EFA_VERSION" "1.48.0" && EFA_EXTRA_ARGS="--disable-ngc"
19+
./efa_installer.sh -y --skip-kmod --skip-limit-conf --no-verify ${EFA_EXTRA_ARGS}
1420
rm -rf /tmp/efa
1521

1622
# Configure OpenMPI — allow root execution

0 commit comments

Comments
 (0)