Skip to content

Commit aa92ef0

Browse files
authored
Revert temp boto3 fix and pin awscli/boto3 (#4509)
* test * fix typo * upgrade awscli * remove fabric and invoke pins * add awscli to requirements, add --upgrade * same changes to test requirements * pin awscli and boto3 to current latest versions; test pt inference 2.5 ec2 * test pt inference 2.5 sm * Update ['dlc_developer_config.toml'] dlc_developer_config.toml: { 'build': { 'build_frameworks': ['pytorch'], 'build_inference': True, 'build_training': False}, 'buildspec_override': { 'dlc-pr-pytorch-inference': 'pytorch/inference/buildspec-2-4-ec2.yml'}, 'dev': { 'arm64_mode': False, 'deep_canary_mode': False, 'graviton_mode': False, 'neuronx_mode': False}, 'test': { 'ec2_tests': True, 'ecs_tests': True, 'eks_tests': True, 'sagemaker_local_tests': True, 'sagemaker_remote_tests': True, 'sanity_tests': True, 'security_tests': True}} * Update ['dlc_developer_config.toml'] dlc_developer_config.toml: { 'build': { 'build_frameworks': ['pytorch'], 'build_inference': True, 'build_training': False}, 'buildspec_override': { 'dlc-pr-pytorch-arm64-inference': 'pytorch/inference/buildspec-arm64-2-5-ec2.yml'}, 'dev': { 'arm64_mode': True, 'deep_canary_mode': False, 'graviton_mode': False, 'neuronx_mode': False}, 'test': { 'ec2_tests': True, 'ecs_tests': True, 'eks_tests': True, 'sagemaker_local_tests': True, 'sagemaker_remote_tests': True, 'sanity_tests': True, 'security_tests': True}} * Update ['dlc_developer_config.toml'] dlc_developer_config.toml: { 'build': { 'build_frameworks': ['pytorch'], 'build_inference': False, 'build_training': True}, 'buildspec_override': { 'dlc-pr-pytorch-training': 'pytorch/training/buildspec-2-5-sm.yml'}, 'dev': { 'arm64_mode': False, 'deep_canary_mode': False, 'graviton_mode': False, 'neuronx_mode': False}, 'test': { 'ec2_tests': True, 'ecs_tests': True, 'eks_tests': True, 'sagemaker_local_tests': True, 'sagemaker_remote_tests': True, 'sanity_tests': True, 'security_tests': True}} * Update ['dlc_developer_config.toml'] dlc_developer_config.toml: { 'build': { 'build_frameworks': ['tensorflow'], 'build_inference': True, 'build_training': False}, 'buildspec_override': { 'dlc-pr-tensorflow-2-inference': 'tensorflow/inference/buildspec-2-18-ec2.yml'}, 'dev': { 'arm64_mode': False, 'deep_canary_mode': False, 'graviton_mode': False, 'neuronx_mode': False}, 'test': { 'ec2_tests': True, 'ecs_tests': True, 'eks_tests': True, 'sagemaker_local_tests': True, 'sagemaker_remote_tests': True, 'sanity_tests': True, 'security_tests': True}} * Restore ['dlc_developer_config.toml'] dlc_developer_config.toml: ('Restore to ' 'https://raw.githubusercontent.com/aws/deep-learning-containers/master/dlc_developer_config.toml')
1 parent fda31e7 commit aa92ef0

File tree

3 files changed

+6
-10
lines changed

3 files changed

+6
-10
lines changed

src/patch_helper.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -305,9 +305,6 @@ def initiate_multithreaded_autopatch_prep(PRE_PUSH_STAGE_IMAGES, make_dummy_boto
305305
f"""pip install -r {os.path.join(os.sep, get_cloned_folder_path(), "test", "requirements.txt")}""",
306306
hide=False,
307307
)
308-
# temporary workaround for breaking boto3 version
309-
run("pip uninstall -y boto3 botocore s3transfer")
310-
run("pip install boto3==1.35.75") # minimum required version for sagemaker dependency currently
311308

312309
folder_path_outside_clone = os.path.join(os.sep, *get_cloned_folder_path().split(os.sep)[:-1])
313310
download_path = os.path.join(os.sep, folder_path_outside_clone, "patch-dlc")

src/requirements.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1+
awscli==1.37.6
2+
boto3==1.36.6
3+
fabric
4+
invoke
15
wheel==0.44.0
26
docker==4.2.0
3-
fabric==2.5.0
4-
#unpin when fabric releases v3.1 Related Issue https://github.com/fabric/fabric/issues/2263
5-
invoke<2.1.0
67
pyfiglet==0.8.post1
78
reprint==0.5.2
89
ruamel.yaml==0.18.10
9-
boto3>=1.33
1010
black==23.3.0
1111
junit-xml==1.9
1212
toml==0.10.2

test/requirements.txt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1+
boto3
12
docker
23
fabric
3-
#unpin when fabric releases v3.1 Related Issue https://github.com/fabric/fabric/issues/2263
4-
invoke<2.1.0
4+
invoke
55
junit-xml==1.9
66
packaging
77
# Pin pytest to preserve pytest cache behavior
@@ -12,7 +12,6 @@ pytest-json-report
1212
pytest-xdist
1313
sagemaker>=2,<3
1414
xmltodict
15-
boto3>=1.33
1615
retrying
1716
gitpython
1817
pytz

0 commit comments

Comments
 (0)