Skip to content

Commit ab1e831

Browse files
Add condition to check instance type
1 parent 5f5fa0f commit ab1e831

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

test/vllm/trigger_test.py

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import logging
33
from typing import List
44

5-
from test.test_utils import get_dlc_images
5+
from test.test_utils import get_dlc_images, is_pr_context
66
from test.vllm.eks.eks_test import test_vllm_on_eks
77
from test.vllm.ec2.infra.setup_ec2 import setup
88
from test.vllm.ec2.test_artifacts.test_ec2 import test_vllm_on_ec2
@@ -12,14 +12,19 @@
1212
LOGGER.addHandler(logging.StreamHandler(sys.stdout))
1313

1414

15-
def run_platform_tests(platform: str, images: List[str], commit_id: str, ipv6_enabled: bool):
15+
def run_platform_tests(platform: str, images: List[str]):
1616
"""
1717
Run tests for a specific platform
1818
"""
1919
instance_type = os.getenv("EC2_GPU_INSTANCE_TYPE")
20-
print(f"Running {platform} tests on {instance_type}")
21-
if platform == "ec2" and instance_type == "p4d.24xlarge":
20+
21+
if instance_type == "p4d.24xlarge":
22+
LOGGER.info(f"Skipping tests on {instance_type} instance type")
23+
return
24+
25+
if platform == "ec2":
2226
try:
27+
print(f"Running {platform} tests on {instance_type}")
2328
ec2_resources = setup()
2429
print(ec2_resources)
2530
print("Finished gathering resources required for VLLM EC2 Tests")
@@ -61,8 +66,6 @@ def test():
6166
run_platform_tests(
6267
platform=test_type,
6368
images=standard_images_list,
64-
commit_id=commit_id,
65-
ipv6_enabled=ipv6_enabled,
6669
)
6770

6871

0 commit comments

Comments
 (0)