Skip to content

Commit d998754

Browse files
committed
fix(ci): prevent release job from inheriting upstream skip
The release job used a bare conditional (needs.release-gate.outputs.should-release == 'true') with no status check function. When upstream test jobs (security/sagemaker/efa) were skipped, GitHub Actions propagated that skip to release, so it never ran even when release-gate succeeded and set should-release=true. Add !failure() && !cancelled() to break the propagated skip, matching the pattern already used by release-gate and the test jobs. Signed-off-by: Sally Seok <sallyseo@amazon.com>
1 parent a2586f3 commit d998754

9 files changed

Lines changed: 9 additions & 9 deletions

.github/workflows/base.pipeline.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ jobs:
110110
config-file: ${{ inputs.config-file }}
111111

112112
release:
113-
if: ${{ needs.release-gate.outputs.should-release == 'true' }}
113+
if: ${{ !failure() && !cancelled() && needs.release-gate.outputs.should-release == 'true' }}
114114
needs: [build, release-gate]
115115
uses: ./.github/workflows/_reusable.release-image.yml
116116
with:

.github/workflows/huggingface-vllm.pipeline.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ jobs:
142142
config-file: ${{ inputs.config-file }}
143143

144144
release:
145-
if: ${{ needs.release-gate.outputs.should-release == 'true' }}
145+
if: ${{ !failure() && !cancelled() && needs.release-gate.outputs.should-release == 'true' }}
146146
needs: [build, release-gate]
147147
uses: ./.github/workflows/_reusable.release-image.yml
148148
with:

.github/workflows/lambda.pipeline.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ jobs:
193193
config-file: ${{ inputs.config-file }}
194194

195195
release:
196-
if: ${{ needs.release-gate.outputs.should-release == 'true' }}
196+
if: ${{ !failure() && !cancelled() && needs.release-gate.outputs.should-release == 'true' }}
197197
needs: [build, release-gate]
198198
uses: ./.github/workflows/_reusable.release-image.yml
199199
with:

.github/workflows/pytorch.pipeline.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ jobs:
242242
config-file: ${{ inputs.config-file }}
243243

244244
release:
245-
if: ${{ needs.release-gate.outputs.should-release == 'true' }}
245+
if: ${{ !failure() && !cancelled() && needs.release-gate.outputs.should-release == 'true' }}
246246
needs: [build, release-gate]
247247
uses: ./.github/workflows/_reusable.release-image.yml
248248
with:

.github/workflows/ray.pipeline.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ jobs:
186186
config-file: ${{ inputs.config-file }}
187187

188188
release:
189-
if: ${{ needs.release-gate.outputs.should-release == 'true' }}
189+
if: ${{ !failure() && !cancelled() && needs.release-gate.outputs.should-release == 'true' }}
190190
needs: [build, release-gate]
191191
uses: ./.github/workflows/_reusable.release-image.yml
192192
with:

.github/workflows/sglang.pipeline.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ jobs:
208208
config-file: ${{ inputs.config-file }}
209209

210210
release:
211-
if: ${{ needs.release-gate.outputs.should-release == 'true' }}
211+
if: ${{ !failure() && !cancelled() && needs.release-gate.outputs.should-release == 'true' }}
212212
needs: [build, release-gate]
213213
uses: ./.github/workflows/_reusable.release-image.yml
214214
with:

.github/workflows/vllm-omni.pipeline.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ jobs:
171171
config-file: ${{ inputs.config-file }}
172172

173173
release:
174-
if: ${{ needs.release-gate.outputs.should-release == 'true' }}
174+
if: ${{ !failure() && !cancelled() && needs.release-gate.outputs.should-release == 'true' }}
175175
needs: [build, release-gate]
176176
uses: ./.github/workflows/_reusable.release-image.yml
177177
with:

.github/workflows/vllm.pipeline.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ jobs:
207207
config-file: ${{ inputs.config-file }}
208208

209209
release:
210-
if: ${{ needs.release-gate.outputs.should-release == 'true' }}
210+
if: ${{ !failure() && !cancelled() && needs.release-gate.outputs.should-release == 'true' }}
211211
needs: [build, release-gate]
212212
uses: ./.github/workflows/_reusable.release-image.yml
213213
with:

.github/workflows/xgboost.pipeline.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ jobs:
173173
config-file: ${{ inputs.config-file }}
174174

175175
release:
176-
if: ${{ needs.release-gate.outputs.should-release == 'true' }}
176+
if: ${{ !failure() && !cancelled() && needs.release-gate.outputs.should-release == 'true' }}
177177
needs: [build, release-gate]
178178
uses: ./.github/workflows/_reusable.release-image.yml
179179
with:

0 commit comments

Comments
 (0)