Skip to content

Commit f735c7f

Browse files
author
Yadan Wei
committed
run all tests and skip data service for tf2.18
1 parent 1043b17 commit f735c7f

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

dlc_developer_config.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,13 +64,13 @@ ecs_tests = true
6464
eks_tests = true
6565
ec2_tests = true
6666
# Set it to true if you are preparing a Benchmark related PR
67-
ec2_benchmark_tests = false
67+
ec2_benchmark_tests = true
6868

6969
### Set ec2_tests_on_heavy_instances = true to be able to run any EC2 tests that use large/expensive instance types by
7070
### default. If false, these types of tests will be skipped while other tests will run as usual.
7171
### These tests are run in EC2 test jobs, so ec2_tests must be true if ec2_tests_on_heavy_instances is true.
7272
### Off by default (set to false)
73-
ec2_tests_on_heavy_instances = false
73+
ec2_tests_on_heavy_instances = true
7474

7575
### SM specific tests
7676
### On by default

test/dlc_tests/ec2/tensorflow/training/test_tensorflow_training.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -370,12 +370,13 @@ def test_tensorflow_dataservice_cpu(
370370

371371
# Testing Data Service on only one GPU instance
372372
# Skip test for TF 2.3 and below
373+
# skip temporily with this issue https://github.com/aws/deep-learning-containers/pull/4485
373374
@pytest.mark.integration("tensorflow-dataservice-test")
374375
@pytest.mark.model("N/A")
375376
@pytest.mark.team("frameworks")
376377
@pytest.mark.parametrize("ec2_instance_type", TF_EC2_GPU_INSTANCE_TYPE, indirect=True)
377378
def test_tensorflow_dataservice_gpu(
378-
tensorflow_training, ec2_connection, tf24_and_above_only, gpu_only, ec2_instance_type
379+
tensorflow_training, ec2_connection, tf24_and_above_only, gpu_only, ec2_instance_type, skip_tf218
379380
):
380381
if test_utils.is_image_incompatible_with_instance_type(tensorflow_training, ec2_instance_type):
381382
pytest.skip(
@@ -398,12 +399,13 @@ def test_tensorflow_distribute_dataservice_cpu(
398399

399400
# Testing Data Service Distributed mode on only one GPU instance
400401
# Skip test for TF 2.3 and below
402+
# skip temporily with this issue https://github.com/aws/deep-learning-containers/pull/4485
401403
@pytest.mark.integration("tensorflow-dataservice-distribute-test")
402404
@pytest.mark.model("N/A")
403405
@pytest.mark.team("frameworks")
404406
@pytest.mark.parametrize("ec2_instance_type", TF_EC2_GPU_INSTANCE_TYPE, indirect=True)
405407
def test_tensorflow_distribute_dataservice_gpu(
406-
tensorflow_training, ec2_connection, tf24_and_above_only, gpu_only, ec2_instance_type
408+
tensorflow_training, ec2_connection, tf24_and_above_only, gpu_only, ec2_instance_type, skip_tf218
407409
):
408410
if test_utils.is_image_incompatible_with_instance_type(tensorflow_training, ec2_instance_type):
409411
pytest.skip(

0 commit comments

Comments
 (0)