Fix go lint errors

Author: rajeshvenkata

.github/workflows/golangci-lint.yml

@@ -11,16 +11,16 @@ jobs:
     name: lint
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-go@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v5
         with:
-          go-version: '1.22'
+          go-version: '1.24'
           check-latest: true
           cache: true
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v3
+        uses: golangci/golangci-lint-action@v8
         with:
-          version: v1.55.2
+          version: v2.1.0
           # Disable package caching to avoid a double cache with setup-go.
           skip-pkg-cache: true
           args: --timeout 10m

.gitignore

@@ -19,6 +19,7 @@ bin
 
 # editor and IDE paraphernalia
 .idea
+.vscode
 *.swp
 *.swo
 *~

.golangci.yml

@@ -1,4 +1,8 @@
+version: "2"
+
 run:
   timeout: 10m
-  skip-dirs:
-    - "api/v1alpha3"
+
+linters:
+  disable:
+    - staticcheck

controllers/healthcheck.go

@@ -63,7 +63,7 @@ func (r *EtcdadmClusterReconciler) performEndpointHealthCheck(ctx context.Contex
 		return errors.Wrap(err, "error checking etcd member health")
 	}
 	// reuse connection
-	defer resp.Body.Close()
+	defer func() { _ = resp.Body.Close() }()
 
 	if resp.StatusCode != http.StatusOK {
 		return errors.Wrap(err, "Etcd member not ready, retry")
@@ -136,7 +136,7 @@ func isPortOpen(ctx context.Context, endpoint string) bool {
 	}
 
 	if conn != nil {
-		conn.Close()
+		_ = conn.Close()
 		return true
 	}
 

controllers/periodic_healthcheck.go

@@ -127,7 +127,7 @@ func (r *EtcdadmClusterReconciler) periodicEtcdMembersHealthCheck(ctx context.Co
 	log := r.Log.WithValues("EtcdadmCluster", klog.KObj(etcdCluster))
 
 	if etcdCluster.Spec.Replicas == nil {
-		err := fmt.Errorf("Replicas is nil")
+		err := fmt.Errorf("replicas is nil")
 		log.Error(err, "Error performing healthcheck")
 		return err
 	}

controllers/scale.go

@@ -55,7 +55,7 @@ func (r *EtcdadmClusterReconciler) removeEtcdMachine(ctx context.Context, ec *et
 	if etcdClient == nil {
 		return fmt.Errorf("could not create etcd client")
 	}
-	defer etcdClient.Close()
+	defer func() { _ = etcdClient.Close() }()
 
 	return r.removeEtcdMemberAndDeleteMachine(ctx, etcdClient, peerURL, machineToDelete)