swap condition and cache check

Author: jmdeal

pkg/controllers/nodeclass/validation.go

@@ -69,20 +69,6 @@ func NewValidationReconciler(ec2api sdk.EC2API, amiProvider amifamily.Provider,
 
 // nolint:gocyclo
 func (v *Validation) Reconcile(ctx context.Context, nodeClass *v1.EC2NodeClass) (reconcile.Result, error) {
-	if val, ok := v.cache.Get(v.cacheKey(nodeClass)); ok {
-		// We still update the status condition even if it's cached since we may have had a conflict error previously
-		if val == "" {
-			nodeClass.StatusConditions().SetTrue(v1.ConditionTypeValidationSucceeded)
-		} else {
-			nodeClass.StatusConditions().SetFalse(
-				v1.ConditionTypeValidationSucceeded,
-				val.(string),
-				ValidationConditionMessages[val.(string)],
-			)
-		}
-		return reconcile.Result{}, nil
-	}
-
 	for _, cond := range []string{
 		v1.ConditionTypeAMIsReady,
 		v1.ConditionTypeInstanceProfileReady,
@@ -100,6 +86,20 @@ func (v *Validation) Reconcile(ctx context.Context, nodeClass *v1.EC2NodeClass)
 		return reconcile.Result{}, nil
 	}
 
+	if val, ok := v.cache.Get(v.cacheKey(nodeClass)); ok {
+		// We still update the status condition even if it's cached since we may have had a conflict error previously
+		if val == "" {
+			nodeClass.StatusConditions().SetTrue(v1.ConditionTypeValidationSucceeded)
+		} else {
+			nodeClass.StatusConditions().SetFalse(
+				v1.ConditionTypeValidationSucceeded,
+				val.(string),
+				ValidationConditionMessages[val.(string)],
+			)
+		}
+		return reconcile.Result{}, nil
+	}
+
 	nodeClaim := &karpv1.NodeClaim{
 		Spec: karpv1.NodeClaimSpec{
 			NodeClassRef: &karpv1.NodeClassReference{