Skip to content

Run make docgen as part of CI process #3752

Open
@jonathan-innis

Description

@jonathan-innis

Tell us about your request

make docgen should be run as part of the standard CI process. Without it in the CI process, it's possible for a contributor to open a PR against karpenter that breaks our docgen script but this won't be realized until after the PR has been approved and merged

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

Authentication with the AWS APIs mean that we need a lower-level of permission for the CI account that is going to be fetching instance types in the PR CI run

Are you currently working around this issue?

Testing locally, but the local environment does not always accurately replicate the CI environment.

Additional Context

No response

Attachments

No response

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    automationIssues about the Karpenter's automation processeschoreIssues that are refactors or code cleanup tasks

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions