Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add values.schema.json to karpenter and karpenter-crd helm charts #6503

Closed
wants to merge 2 commits into from

Conversation

aviatus
Copy link

@aviatus aviatus commented Jul 12, 2024

Fixes #5065

Description
Auto values.schema.json generator added to project release workflow. The go package helm-schema(using on cilium) is used for that objective with loose settings. The go package does support more strict rule implementations with changes on values.yaml. Only label typos and value type mistakes are prevented but conditioned or required rules can be implemented on request.

How was this change tested?
The tested via makefile.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aviatus aviatus requested a review from a team as a code owner July 12, 2024 11:04
@aviatus aviatus requested a review from jmdeal July 12, 2024 11:04
Copy link

netlify bot commented Jul 12, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit f61028c
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66910da30b56410008da3ccd
😎 Deploy Preview https://deploy-preview-6503--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add values.schema.json to karpenter and karpenter-crd helm charts
1 participant