Classify InstanceProfile creation failures/Subnet failures/SecurityGroup failures as terminal or non-terminal

[jonathan-innis]

Description

What problem are you trying to solve?

Right now, whenever we get an error back from the instance profile provider, we just leave the status condition for InstanceProfileReady in the Unknown state -- this is a little confusing when the error may not in fact be retryable (such as an authorization error or the number of instance profiles hitting the limit in the account). The same logic could be applied to the security group, subnet, capacity reservation, etc. where we classify authorization errors as terminal and mark the status condition as false in those scenarios.

We should classify these errors as retryable or non-retryable and then mark the status condition as Unknown or False respectively.

How important is this feature to you?

This would ensure that we have a more consistent view of our status conditions and signal things that need user intervention vs. things that are retryable.

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment