See a ton of `failed listing instance types for` errors when deleting EC2NodeClass

[jonathan-innis]

Description

Observed Behavior:

During the termination of an EC2NodeClass, we can see that the disruption controller reacts by throwing a lot of spurious errors for failing to list instance types. We should see if there is either a way to 1) Not return an error like this when we get into this state OR 2) Handle this more gracefully in the disruption controller code so that we don't aggressively log like this under normal operations.

{"level":"ERROR","time":"2025-03-06T00:57:24.539Z","logger":"controller","caller":"disruption/helpers.go:147","message":"failed listing instance types for wyrmbush-2-faidzm8t6c","commit":"791df8a","controller":"disruption","namespace":"","name":"","reconcileID":"da55d524-085d-420e-a0e7-cd8df4dbae33","error":"resolving node class, ec2nodeclasses.karpenter.k8s.aws \"jackaliridescent-1-jadothcdhm\" is terminating, treating as not found"}

Expected Behavior:

We shouldn't log a ton of spurious logs

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment