From 933511def6fce64b472e74611863abad26ae22cc Mon Sep 17 00:00:00 2001 From: Daniel Ricart Date: Fri, 31 Jan 2025 16:10:08 +0100 Subject: [PATCH 1/2] Add ability to the helm chart to specify initContainers. Currently, the current helm chart does not support adding initContainers to the deployment for things like ensuring that IAM credentials are valid. This PR aims to support users to especify initContainers in the Values file. The implementation follows the practices applied in other similar fields that are already present. --- charts/karpenter/templates/deployment.yaml | 4 ++++ charts/karpenter/values.yaml | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/charts/karpenter/templates/deployment.yaml b/charts/karpenter/templates/deployment.yaml index 990ce486292e..44ab4ed35d8a 100644 --- a/charts/karpenter/templates/deployment.yaml +++ b/charts/karpenter/templates/deployment.yaml @@ -195,6 +195,10 @@ spec: {{- toYaml . | nindent 12 }} {{- end }} {{- end }} + {{- with .Values.initContainers }} + initContainers: + {{- toYaml . | nindent 8 }} + {{- end }} {{- with .Values.nodeSelector }} nodeSelector: {{- toYaml . | nindent 8 }} diff --git a/charts/karpenter/values.yaml b/charts/karpenter/values.yaml index bc24a5852ee9..5cdb292f405b 100644 --- a/charts/karpenter/values.yaml +++ b/charts/karpenter/values.yaml @@ -68,6 +68,11 @@ dnsConfig: {} # options: # - name: ndots # value: "1" +# -- add additional initContainers to run before karpenter container starts +initContainers: {} +# - name: list-ec2-instances +# image: dockerhub.containers.mpi-internal.com/amazon/aws-cli:latest +# command: [ 'aws', 'ec2', 'describe-instance-types'] # -- Node selectors to schedule the pod to nodes with labels. nodeSelector: kubernetes.io/os: linux From 020345a860f2f71bc2f070544245d0cd90795f54 Mon Sep 17 00:00:00 2001 From: Daniel Ricart <2780546+danielricart@users.noreply.github.com> Date: Fri, 31 Jan 2025 17:40:15 +0100 Subject: [PATCH 2/2] Update values.yaml --- charts/karpenter/values.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/karpenter/values.yaml b/charts/karpenter/values.yaml index 5cdb292f405b..707a8747e044 100644 --- a/charts/karpenter/values.yaml +++ b/charts/karpenter/values.yaml @@ -71,7 +71,7 @@ dnsConfig: {} # -- add additional initContainers to run before karpenter container starts initContainers: {} # - name: list-ec2-instances -# image: dockerhub.containers.mpi-internal.com/amazon/aws-cli:latest +# image: amazon/aws-cli:latest # command: [ 'aws', 'ec2', 'describe-instance-types'] # -- Node selectors to schedule the pod to nodes with labels. nodeSelector: