Ignore munlock failures
#2804
Merged
Ignore munlock failures
#2804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feliperodri
reviewed
May 5, 2021
lrstewart
approved these changes
May 5, 2021
feliperodri
approved these changes
May 5, 2021
toidiu
reviewed
May 6, 2021
| free(ptr); | ||
| POSIX_ENSURE(munlock_rc == 0, S2N_ERR_MUNLOCK); |
There was a problem hiding this comment.
should we also remove S2N_ERR_MUNLOCK from s2n_errno.c since this doesnt exist anymore?
There was a problem hiding this comment.
thinking about this more, removing S2N_ERR_MUNLOCK might be a breaking api change so possibly no good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
None.
Related to: #2803.
fix: #2803
Description of changes:
Instead of failing on
munlock, we now do a best-effortmunlock.Call-outs:
We might want to refactor this part later on, and properly handle
munlockfailures. I left #2803 open for discussion.Testing:
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.